Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-1146 add support for instance fleet in EMR #14758

Closed
wants to merge 4 commits into from
Closed

issue-1146 add support for instance fleet in EMR #14758

wants to merge 4 commits into from

Conversation

c4po
Copy link
Contributor

@c4po c4po commented Aug 20, 2020 •
edited by anGie44
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1146

Release note for CHANGELOG:

* resource/aws_emr_cluster: Support instance fleet ([#1146](https://github.com/terraform-providers/terraform-provider-aws/issues/1146))
* **New Resource:** `aws_emr_instance_fleet`: ([#1146](https://github.com/terraform-providers/terraform-provider-aws/issues/1146))

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@c4po c4po requested a review from a team August 20, 2020 19:11
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 20, 2020
@c4po c4po closed this Aug 20, 2020
@c4po c4po reopened this Aug 20, 2020
@bflad bflad self-assigned this Aug 21, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 21, 2020
@bflad
Copy link
Contributor

bflad commented Aug 21, 2020

Thank you for your hard work on this, @c4po! 😄 I would love to continue working with you on these EMR pull requests and ensure they get merged in the next few releases. 👍

To simplify things for both of us, could you split this PR into two separate ones? One for the initial instance fleet handling in the aws_emr_cluster resource, then a separate one for the new aws_emr_instance_fleet resource. This will allow us to focus on getting the base support in and tidied up, rather than delaying the second half of the functionality for any potentially different review items there since implementing a new resource is much more work/review. Thank you so much.

@c4po
Copy link
Contributor Author

c4po commented Aug 22, 2020

@bflad I can split this into 2 PRs. But the EMR cluster can only have one type of instance group. If we have instance fleet for master and core node, we must provide instance fleet for task node. so these 2 part of changes need be add together to make it works.

@c4po
Copy link
Contributor Author

c4po commented Aug 23, 2020 •
edited
Loading

the first part is here #14788
the second part is here #14813
please review it
the code for second part (add aws_emr_instance_fleet resource) has many common function shared with the first part. I will remove them once the first part get merged.

@c4po c4po closed this Aug 24, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/emr Issues and PRs that pertain to the emr service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EMR create a new resource aws_emr_instances_fleet
2 participants
@c4po @bflad