Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/wafv2_web_acl: remove force_new property from arguments to prevent resource recreation #14616

Merged
merged 1 commit into from
Aug 13, 2020
+364 −25
Merged

resource/wafv2_web_acl: remove force_new property from arguments to prevent resource recreation #14616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions aws/resource_aws_wafv2_web_acl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ func resourceAwsWafv2WebACL() *schema.Resource {
"name": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: validation.StringLenBetween(1, 128),
},
"override_action": {
Expand Down Expand Up @@ -253,7 +252,7 @@ func resourceAwsWafv2WebACLUpdate(d *schema.ResourceData, meta interface{}) erro
Scope: aws.String(d.Get("scope").(string)),
LockToken: aws.String(d.Get("lock_token").(string)),
DefaultAction: expandWafv2DefaultAction(d.Get("default_action").([]interface{})),
Rules: expandWafv2Rules(d.Get("rule").(*schema.Set).List()),
Rules: expandWafv2WebACLRules(d.Get("rule").(*schema.Set).List()),
Copy link
Contributor Author

@anGie44 anGie44 Aug 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses TestAccAwsWafv2WebACL_ManagedRuleGroupStatement and TestAccAwsWafv2WebACL_RateBasedStatement test failures as now they actually attempt to do an update vs. a destroy/create, exposing the bug reported in #14035

VisibilityConfig: expandWafv2VisibilityConfig(d.Get("visibility_config").([]interface{})),
}

Expand Down
Loading