Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/instance: Function for availability zone config #14568

Merged
merged 1 commit into from
Aug 13, 2020
Merged

r/instance: Function for availability zone config #14568

merged 1 commit into from
Aug 13, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 11, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12995

Release note for CHANGELOG:

NONE

Output from GovCloud acceptance testing:

--- PASS: TestAccAWSInstanceDataSource_privateIP (97.68s)
--- PASS: TestAccAWSInstanceDataSource_VPC (117.44s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (130.15s)

Output from commercial acceptance testing:

--- PASS: TestAccAWSInstanceDataSource_privateIP (129.91s)
--- PASS: TestAccAWSInstanceDataSource_VPC (124.76s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (142.31s)

@YakDriver YakDriver requested a review from a team August 11, 2020 18:38
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 11, 2020
@YakDriver YakDriver changed the title r/instance: Config func to help remove hardcoded AZs r/instance: Function for availability zone config Aug 11, 2020
This was referenced Aug 11, 2020
Merged
Merged
Merged
anGie44
anGie44 approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments, otherwise LGTM 👍

@ghost ghost added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 13, 2020
@YakDriver YakDriver merged commit 0a61ba7 into master Aug 13, 2020
@YakDriver YakDriver deleted the td-hardaz-func-config branch August 13, 2020 16:45
@ewbankkit ewbankkit mentioned this pull request Aug 13, 2020
Merged
@YakDriver YakDriver added this to the v3.3.0 milestone Aug 17, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

This has been released in version 3.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
@ghost
Copy link

ghost commented Sep 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. partition/aws-us-gov Pertains to the aws-us-gov partition. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @anGie44