Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_rds_cluster: Fix and standardize TestAccAWSRDSCluster_EncryptedCrossRegionReplication #14491

Merged
merged 1 commit into from
Aug 6, 2020
Merged

tests/resource/aws_rds_cluster: Fix and standardize TestAccAWSRDSCluster_EncryptedCrossRegionReplication #14491

merged 1 commit into from
Aug 6, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 6, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #10333
Reference: #14384

Release note for CHANGELOG:

NONE

Previously:

    TestAccAWSRDSCluster_EncryptedCrossRegionReplication: testing.go:684: Step 0 error: errors during apply:

        Error: error creating RDS cluster: InvalidParameterCombination: Cannot specify database name for cross region replication cluster

Output from acceptance testing:

--- PASS: TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId (1545.00s)

@bflad
tests/resource/aws_rds_cluster: Fix and standardize TestAccAWSRDSClus…
6ba4723 
…ter_EncryptedCrossRegionReplication

Reference: #10333
Reference: #14384

Previously:

```
    TestAccAWSRDSCluster_EncryptedCrossRegionReplication: testing.go:684: Step 0 error: errors during apply:

        Error: error creating RDS cluster: InvalidParameterCombination: Cannot specify database name for cross region replication cluster
```

Output from acceptance testing:

```
--- PASS: TestAccAWSRDSCluster_ReplicationSourceIdentifier_KmsKeyId (1545.00s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Aug 6, 2020
@bflad bflad requested a review from a team August 6, 2020 15:12
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 6, 2020
anGie44
anGie44 approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍 👍

@bflad bflad added this to the v3.1.0 milestone Aug 6, 2020
@bflad bflad merged commit e1f7c47 into master Aug 6, 2020
@bflad bflad deleted the t-aws_rds_cluster-fixes-part1 branch August 6, 2020 22:55
@anGie44
Copy link
Contributor

anGie44 commented Aug 7, 2020 •
edited
Loading

Ah I believe I missed the connection to #14490 🤦‍♀️ -- this test will fail with it merged in as the secondary rds_cluster has the password/username params removed and doesn't refer to a global cluster

#14502 as example workaround

@anGie44 anGie44 mentioned this pull request Aug 7, 2020
Merged
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
service/rds Issues and PRs that pertain to the rds service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @anGie44