Move semaphore notify to test cleanup

[appilon]

In general it is probably not a safe bet to have critical code in a CheckDestroy in V1 (as it does not run when state is nil), in SDKv2, we explicitly don't call Destroy if state is empty. As a result the semaphore leaks and deadlocks against SDKv2, because creation fails due to resource limits (I guess in V1, state != nil so this problem doesn't happen 🤷‍♂️ ), the semaphore is not released. This change uses go1.14's Cleanup helper to ensure the semaphore is released.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

The tests ran without deadlock against SDKv1 or SDKv2

[appilon]

fixed @bflad

[bflad]

Let's get this in 🚀

[ghost]

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!