Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dms_endpoint): add DataFormat, EncryptionMode, and KmsKeyId to the S3 settings block #14340

Conversation

doransmestad
Copy link

@doransmestad doransmestad commented Jul 24, 2020

This pull request adds three new attributes to the S3 settings block of the dms_endpoint resource. This allows the user to specify S3 target endpoint in parquet format as well as specify the KMS key (or just server side sse-s3 encryption) to protect the exported data at rest.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Add `data_format`, `encryption_mode`, and `server_side_encryption_kms_key_id` to the S3 settings block of the aws_dms_endpoint resource.

Output from acceptance testing:

TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAwsDmsEndpoint_S3 -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsDmsEndpoint_S3
=== PAUSE TestAccAwsDmsEndpoint_S3
=== RUN   TestAccAwsDmsEndpoint_S3Encrypted
=== PAUSE TestAccAwsDmsEndpoint_S3Encrypted
=== CONT  TestAccAwsDmsEndpoint_S3
=== CONT  TestAccAwsDmsEndpoint_S3Encrypted
--- PASS: TestAccAwsDmsEndpoint_S3 (143.29s)
--- PASS: TestAccAwsDmsEndpoint_S3Encrypted (252.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	252.696s

@doransmestad doransmestad requested a review from a team July 24, 2020 23:02
@ghost ghost added service/databasemigrationservice documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Jul 24, 2020
@doransmestad doransmestad force-pushed the f-aws_dms_endpoint-add-attributes-to-s3-settings branch from ed5e4cc to 669dadb Compare July 25, 2020 01:20
@doransmestad doransmestad force-pushed the f-aws_dms_endpoint-add-attributes-to-s3-settings branch from 669dadb to f07af1d Compare November 18, 2020 23:28
@doransmestad doransmestad requested a review from a team as a code owner November 18, 2020 23:28
Base automatically changed from master to main January 23, 2021 00:58
@YakDriver
Copy link
Member

YakDriver commented Apr 14, 2021

Related #14620
Related #17591
Related #18750

@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Apr 14, 2021
@anGie44
Copy link
Contributor

anGie44 commented Aug 17, 2021

Hi @doransmestad, thank you for this contribution and apologies for the delay. At this time, we've moved forward with #17591 which overlaps with the changes here. I'm going to close this PR as a result. But please keep a look out for this feature in the next provider release (v3.55.0).

@anGie44 anGie44 closed this Aug 17, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants