Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch multiregion/account testing to SDK V2 compatible pattern #14312

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Switch multiregion/account testing to SDK V2 compatible pattern #14312

merged 1 commit into from
Jul 29, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Jul 23, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@appilon appilon requested a review from a team July 23, 2020 00:44
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 23, 2020
@appilon appilon changed the title Switch to SDK V2 compatible pattern Switch multiregion/account testing to SDK V2 compatible pattern Jul 23, 2020
@appilon appilon force-pushed the td-v2-compatible-factories branch 2 times, most recently from 71e5a72 to 1915934 Compare July 24, 2020 01:20
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 24, 2020
@appilon appilon force-pushed the td-v2-compatible-factories branch from 1915934 to 9cce93f Compare July 24, 2020 18:39
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/backup Issues and PRs that pertain to the backup service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/guardduty Issues and PRs that pertain to the guardduty service. service/ram Issues and PRs that pertain to the ram service. service/rds Issues and PRs that pertain to the rds service. service/route53 Issues and PRs that pertain to the route53 service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 24, 2020
@ewbankkit ewbankkit mentioned this pull request Jul 24, 2020
Closed
@appilon appilon force-pushed the td-v2-compatible-factories branch from 9cce93f to f43c99c Compare July 24, 2020 21:46
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 24, 2020
paultyng
paultyng reviewed Jul 25, 2020
View reviewed changes
aws/provider_test.go Outdated
// effectively singletons for the lifecycle of a resource.Test
var providerNames = []string{"aws", "awseast", "awswest", "awsalternate", "awsus-east-1", "awsalternateaccountalternateregion", "awsalternateaccountsameregion", "awssameaccountalternateregion", "awsthird"}
var factories = make(map[string]terraform.ResourceProviderFactory, len(providerNames))
var singletons = make(map[string]*schema.Provider, len(providerNames))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem to get used anywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right... i guess somewhere in the refactoring i lost the need for it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 removing this 👍

bflad
bflad suggested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to get this working and setup better. Please update the cross-account and cross-region acceptance testing documentation as well, then I think we can get this in.

aws/provider_test.go Outdated
// effectively singletons for the lifecycle of a resource.Test
var providerNames = []string{"aws", "awseast", "awswest", "awsalternate", "awsus-east-1", "awsalternateaccountalternateregion", "awsalternateaccountsameregion", "awssameaccountalternateregion", "awsthird"}
var factories = make(map[string]terraform.ResourceProviderFactory, len(providerNames))
var singletons = make(map[string]*schema.Provider, len(providerNames))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 removing this 👍

@bflad bflad added this to the v3.0.0 milestone Jul 27, 2020
@appilon appilon force-pushed the td-v2-compatible-factories branch from f43c99c to 1cacb60 Compare July 27, 2020 16:39
@bflad bflad mentioned this pull request Jul 27, 2020
Closed
18 tasks
@appilon appilon force-pushed the td-v2-compatible-factories branch from baa57e1 to b4079d4 Compare July 27, 2020 22:50
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 27, 2020
@appilon appilon force-pushed the td-v2-compatible-factories branch from b4079d4 to e66a7a6 Compare July 27, 2020 22:51
@appilon appilon requested a review from bflad July 28, 2020 00:38
bflad
bflad approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 We'll work on decreasing the various "providers" in future issues.

@appilon appilon merged commit 780a103 into master Jul 29, 2020
@appilon appilon deleted the td-v2-compatible-factories branch July 29, 2020 15:37
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng left review comments

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/backup Issues and PRs that pertain to the backup service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/guardduty Issues and PRs that pertain to the guardduty service. service/ram Issues and PRs that pertain to the ram service. service/rds Issues and PRs that pertain to the rds service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53 Issues and PRs that pertain to the route53 service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@appilon @bflad @paultyng