Rewrite TypeSet checks with new helpers [Part 2] #13831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XL
anGie44
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
LGTM just a comment below!
Output of acceptance tests:
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (45.57s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (50.87s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (63.79s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (64.86s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (81.03s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (83.89s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (96.93s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (54.51s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (85.40s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (142.28s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (85.37s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (70.57s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (107.25s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (84.03s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (48.30s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (205.61s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (58.57s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (46.24s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (223.71s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (89.31s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (139.47s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (43.27s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (115.21s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (45.27s)
--- PASS: TestAccAWSAutoScalingGroup_tags (259.26s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (260.94s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (262.39s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (43.75s)
--- PASS: TestAccAWSAutoscalingPolicy_TargetTrack_Predefined (40.13s)
--- PASS: TestAccAWSAutoscalingPolicy_SimpleScalingStepAdjustment (47.55s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (81.03s)
--- PASS: TestAccAWSAutoScalingGroup_basic (291.94s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (294.30s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (112.68s)
--- PASS: TestAccAWSCloudFormationStackSet_disappears (12.00s)
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_Default (0.00s)
--- SKIP: TestAccAWSCloudFormationStackSet_Parameters_NoEcho (0.00s)
--- PASS: TestAccAWSCloudFormationStackSet_basic (13.83s)
--- PASS: TestAccAWSAutoscalingPolicy_basic (80.38s)
--- PASS: TestAccAWSAutoscalingPolicy_disappears (77.43s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (321.76s)
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (28.78s)
--- PASS: TestAccAWSCloudFormationStackSet_Description (30.13s)
--- PASS: TestAccAWSCloudFormationStackSet_Name (25.93s)
--- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (29.51s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (30.75s)
--- PASS: TestAccAWSAutoscalingPolicy_zerovalue (79.07s)
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (30.94s)
--- PASS: TestAccAWSAutoscalingPolicy_TargetTrack_Custom (95.15s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (134.72s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (61.33s)
--- PASS: TestAccAWSCognitoIdentityPoolRolesAttachment_disappears (12.73s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (372.54s)
--- PASS: TestAccAWSCloudFormationStack_basic (59.42s)
--- PASS: TestAccAWSCognitoIdentityPoolRolesAttachment_roleMappingsWithAmbiguousRoleResolutionError (8.99s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (374.92s)
--- PASS: TestAccAWSCognitoIdentityPoolRolesAttachment_roleMappingsWithRulesTypeError (9.17s)
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (71.94s)
--- PASS: TestAccAWSCognitoIdentityPoolRolesAttachment_basic (32.81s)
--- PASS: TestAccAWSCognitoIdentityPoolRolesAttachment_roleMappings (34.56s)
--- PASS: TestAccAWSCognitoIdentityPoolRolesAttachment_roleMappingsWithTokenTypeError (8.64s)
--- PASS: TestAccAWSCloudFormationStack_yaml (59.30s)
--- PASS: TestAccAWSCloudFormationStack_withTransform (45.20s)
--- PASS: TestAccAWSCloudFormationStack_disappears (63.24s)
--- PASS: TestAccAWSCognitoIdentityPool_basic (15.83s)
--- PASS: TestAccAWSCloudFormationStack_allAttributes (61.49s)
--- PASS: TestAccAWSCognitoUserPoolClient_basic (12.04s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (68.72s)
--- SKIP: TestAccAWSCognitoUserPoolDomain_custom (0.00s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (11.81s)
--- PASS: TestAccAWSCognitoIdentityPool_supportedLoginProviders (23.08s)
--- PASS: TestAccAWSCognitoIdentityPool_cognitoIdentityProviders (23.17s)
--- PASS: TestAccAWSCognitoUserPoolClient_disappears (11.51s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (66.23s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (18.84s)
--- PASS: TestAccAWSCognitoIdentityPool_samlProviderArns (28.37s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (20.92s)
--- PASS: TestAccAWSCognitoIdentityPool_tags (24.63s)
--- PASS: TestAccAWSCognitoUserPool_basic (12.59s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (12.28s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (21.27s)
--- PASS: TestAccAWSCognitoUserPoolDomain_basic (17.52s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (18.04s)
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (19.01s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (24.50s)
--- SKIP: TestAccAWSCognitoUserPool_withEmailConfiguration (0.00s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (87.04s)
--- PASS: TestAccAWSCognitoUserPool_withAdvancedSecurityMode (25.65s)
--- PASS: TestAccAWSCognitoUserPoolClient_analyticsConfig (36.05s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (428.22s)
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (18.09s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (23.68s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (32.86s)
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (18.19s)
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (18.40s)
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (17.87s)
--- PASS: TestAccAWSCloudFormationStack_withParams (114.47s)
--- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (17.28s)
--- PASS: TestAccAWSCognitoUserPool_withTags (24.15s)
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (16.93s)
--- PASS: TestAccAWSCognitoUserPool_withSchemaAttributes (18.13s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (37.81s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (117.96s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (45.93s)
--- PASS: TestAccAWSCognitoIdentityPool_addingNewProviderKeepsOldProvider (73.70s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (48.44s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (57.78s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (49.35s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (53.22s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (45.14s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (476.50s)
--- PASS: TestAccAWSCognitoUserPool_update (41.99s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (630.46s)
Following tests failed but are known errors with error messages unrelated to these changes:
Account...should have '...-Execution' role with trust relationship to Role ...
--- FAIL: TestAccAWSCloudFormationStackSetInstance_RetainStack (39.10s)
--- FAIL: TestAccAWSCloudFormationStackSetInstance_basic (36.55s)
--- FAIL: TestAccAWSCloudFormationStackSetInstance_disappears (39.12s)
--- FAIL: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (48.42s)
--- FAIL: TestAccAWSCognitoIdentityPool_openidConnectProviderArns (14.21s)
--- FAIL: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (35.89s)
Comment on lines
+1010
to
1012
| // TODO: TypeSet hash | ||
| testAccCheckAWSAutoScalingGroupInitialLifecycleHookExists( | ||
| "aws_autoscaling_group.bar", "initial_lifecycle_hook.391359060.name"), |
There was a problem hiding this comment.
should we still keep DisableBinaryDriver: true, to be able to support this check for the time being?
There was a problem hiding this comment.
Yes we could, I will switch it back
There was a problem hiding this comment.
oh ok! wasn't sure if it would cause problems while running the tests in the binary driver testing environment in TC
There was a problem hiding this comment.
the test would just error if we switched to V2 of the SDK today is all. DisableBinaryDriver is not an option for V2 of the SDK, but keeping it set to true is a good breadcrumb for me (even with the TODO)
| "developer_only_attribute": "false", | ||
| "mutable": "false", | ||
| "name": "email", | ||
| "number_attribute_constraints.#": "0", |
There was a problem hiding this comment.
👏 didn't know these count checks were supported !
appilon
force-pushed
the
td-remove-set-checks-2
branch
from
fc2cdbe
to
a5c288f
Compare
ghost
added
size/L
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These checks have been rewritten using the new helpers which avoids using set hashes. The helpers have somewhat exhaustive unit tests so the hope is this can be merged in chunks without waiting on acceptance tests.
Community Note
Relates #13556
Release note for CHANGELOG:
Output from acceptance testing: