Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/wafv2_web_acl: update method params in acctest check #13736

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 12, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/wafv2_web_acl: remove extra param in acctest check method updated in #13674

Output from acceptance testing:

--- PASS: TestAccAwsWafv2WebACL_Disappears (82.96s)
--- PASS: TestAccAwsWafv2WebACL_Minimal (118.95s)
--- PASS: TestAccAwsWafv2WebACL_ChangeNameForceNew (209.82s)
--- PASS: TestAccAwsWafv2WebACL_RateBasedStatement (233.68s)
--- PASS: TestAccAwsWafv2WebACL_ManagedRuleGroupStatement (234.70s)
--- PASS: TestAccAwsWafv2WebACL_Basic (239.86s)
--- PASS: TestAccAwsWafv2WebACL_Tags (259.57s)
--- PASS: TestAccAwsWafv2WebACL_RuleGroupReferenceStatement (296.79s)

@anGie44 anGie44 requested a review from a team June 12, 2020 18:34
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/wafv2 Issues and PRs that pertain to the wafv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 12, 2020
@anGie44 anGie44 marked this pull request as draft June 12, 2020 18:35
@anGie44 anGie44 added this to the v2.67.0 milestone Jun 12, 2020
@pvanbuijtene
Copy link
Contributor

How did this pass the CI tests... I also ran the tests locally without any issue 🤔

@anGie44
Copy link
Contributor Author

anGie44 commented Jun 12, 2020

are you referring to the acceptance tests? it may have been the timing, this PR I merged in changed the method signature #13674

@anGie44 anGie44 marked this pull request as ready for review June 12, 2020 18:54
@pvanbuijtene
Copy link
Contributor

aah ok, was wondering how I caused this... we don't want failing builds :)

@anGie44 anGie44 merged commit fcabc0f into master Jun 12, 2020
@anGie44 anGie44 deleted the t-wafv2-acl-method-params branch June 12, 2020 19:32
@anGie44
Copy link
Contributor Author

anGie44 commented Jun 12, 2020

@pvanbuijtene master is all set for rebasing your PRs that might of been affected by this

@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants