Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BackupVaultNotifications resource #13542

Conversation

KernelPanicAUS
Copy link

@KernelPanicAUS KernelPanicAUS commented May 28, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

resource/aws_backup_vault_notifications: Add support for backup event notifications.

Output from acceptance testing:

$  make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupVaultNotifications_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupVaultNotifications_basic -timeout 120m
=== RUN   TestAccAwsBackupVaultNotifications_basic
=== PAUSE TestAccAwsBackupVaultNotifications_basic
=== CONT  TestAccAwsBackupVaultNotifications_basic
--- PASS: TestAccAwsBackupVaultNotifications_basic (26.43s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       27.998s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/backup Issues and PRs that pertain to the backup service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels May 28, 2020
@KernelPanicAUS KernelPanicAUS marked this pull request as ready for review May 28, 2020 17:43
@KernelPanicAUS KernelPanicAUS requested a review from a team May 28, 2020 17:43
@DrFaust92
Copy link
Collaborator

duplicate of #12501

@KernelPanicAUS KernelPanicAUS force-pushed the feat/add-backup-vault-event-notifications branch from a5ea6af to 93fa538 Compare May 31, 2020 16:08
@KernelPanicAUS KernelPanicAUS force-pushed the feat/add-backup-vault-event-notifications branch from 93fa538 to ddbb072 Compare June 13, 2020 10:43
@DrFaust92
Copy link
Collaborator

duplicate of #12501

@DrFaust92 DrFaust92 closed this Aug 3, 2020
@ghost
Copy link

ghost commented Sep 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 2, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/backup Issues and PRs that pertain to the backup service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants