r/datasync_location_fsx_windows - add resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12353

Release note for CHANGELOG:

resource_aws_datasync_location_fsx_windows - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDataSyncLocationFsxWindows_'
--- PASS: TestAccAWSDataSyncLocationFsxWindows_disappears (3067.59s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_basic (2967.79s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_Subdirectory (3063.13s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_Tags (3012.95s)

[DrFaust92]

I have no clue why linting fails... help is welcome

[ewbankkit]

It could be something to do with the number of source files in the aws directory.
If I move the contents to resource_aws_datasync_location_fsx_windows.go into say resource_aws_datasync_location_efs.go (and delete resource_aws_datasync_location_fsx_windows.go) then everything compiles as usual.

[DrFaust92]

ugh, that sounds like a fun issue. @ewbankkit, is this something that happens locally when running make lint or is it a travis issue? i get different unrelated errors.

[ewbankkit]

I'm building on a standard Ubuntu 18.04 and get

$ make
==> Checking that code complies with gofmt requirements...
go install
# github.com/terraform-providers/terraform-provider-aws/aws
aws/provider.go:439:63: undefined: resourceAwsDataSyncLocationFsxWindows
GNUmakefile:12: recipe for target 'build' failed
make: *** [build] Error 2

which is a bogus error.
I'm looking at ulimit and all that.
Same error on Catalina.

[ewbankkit]

@DrFaust92 Actually, it's the _windows suffix on the file name that causes the problem 😄; See https://golang.org/pkg/go/build/#hdr-Build_Constraints.

[DrFaust92]

gotcha, thanks for the info. im thinking of changing the name to aws_datasync_location_fsx_windows_file_system or aws_datasync_location_windows_fsx, thoughts?

[ewbankkit]

aws_datasync_location_fsx_windows_file_system seems to accurately reflect the resource's purpose.

[DrFaust92]

It Lints!

@ewbankkit, Appreciate your help as always.

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDataSyncLocationFsxWindows_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationFsxWindows_ -timeout 120m
=== RUN   TestAccAWSDataSyncLocationFsxWindows_basic
=== PAUSE TestAccAWSDataSyncLocationFsxWindows_basic
=== RUN   TestAccAWSDataSyncLocationFsxWindows_disappears
=== PAUSE TestAccAWSDataSyncLocationFsxWindows_disappears
=== RUN   TestAccAWSDataSyncLocationFsxWindows_Subdirectory
=== PAUSE TestAccAWSDataSyncLocationFsxWindows_Subdirectory
=== RUN   TestAccAWSDataSyncLocationFsxWindows_Tags
=== PAUSE TestAccAWSDataSyncLocationFsxWindows_Tags
=== CONT  TestAccAWSDataSyncLocationFsxWindows_basic
=== CONT  TestAccAWSDataSyncLocationFsxWindows_Tags
=== CONT  TestAccAWSDataSyncLocationFsxWindows_Subdirectory
=== CONT  TestAccAWSDataSyncLocationFsxWindows_disappears
--- PASS: TestAccAWSDataSyncLocationFsxWindows_Tags (2968.99s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_disappears (3035.71s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_basic (3080.52s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_Subdirectory (3084.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3084.752s

[ghost]

@ewbankkit @DrFaust92 any idea when this will become public? It is currently blocking one of my customers. Thanks!

[breathingdust]

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSDataSyncLocationFsxWindows_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncLocationFsxWindows_ -timeout 120m
=== RUN   TestAccAWSDataSyncLocationFsxWindows_basic
=== PAUSE TestAccAWSDataSyncLocationFsxWindows_basic
=== RUN   TestAccAWSDataSyncLocationFsxWindows_disappears
=== PAUSE TestAccAWSDataSyncLocationFsxWindows_disappears
=== RUN   TestAccAWSDataSyncLocationFsxWindows_subdirectory
=== PAUSE TestAccAWSDataSyncLocationFsxWindows_subdirectory
=== RUN   TestAccAWSDataSyncLocationFsxWindows_tags
=== PAUSE TestAccAWSDataSyncLocationFsxWindows_tags
=== CONT  TestAccAWSDataSyncLocationFsxWindows_basic
=== CONT  TestAccAWSDataSyncLocationFsxWindows_tags
=== CONT  TestAccAWSDataSyncLocationFsxWindows_subdirectory
=== CONT  TestAccAWSDataSyncLocationFsxWindows_disappears
    resource_aws_datasync_location_fsx_windows_file_system_test.go:117: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSDataSyncLocationFsxWindows_basic (2908.00s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_disappears (2968.86s)
 --- PASS: TestAccAWSDataSyncLocationFsxWindows_tags (3259.91s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_subdirectory (3480.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3482.790s

[ghost]

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!