resource/aws_emr_cluster: Fix aws_emr_security_configuration destroy issues

[andrei-ilyin-mh]

This will fix #6279

Rewrite resourceAwsEMRClusterDelete to use cluster state returned by DescribeCluster instead of counting running cluster instances to check is cluster terminated. Previous approach might cause too early deletion of cluster's security group which might block deletion of ENI created for this cluster. In this case orphaned ENI is blocking deletion of security configuration as well as linked security group.

These changes was tested on our environments and has fixed painful security configuration deletion issues.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6279.
Closes #3465.

Release note for CHANGELOG:

* resource/aws_emr_cluster: Fix aws_emr_security_configuration destroy issues

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEMRCluster_security_config'

--- PASS: TestAccAWSEMRCluster_security_config (475.02s)

[xmj]

Is there anything else that needs to be done for this to be merged?

[annyip]

any updates? Would love to see this get merged in

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[breathingdust]

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

[ewbankkit]

LGTM 🚀.

--- PASS: TestAccEMRCluster_basic (498.93s)
--- PASS: TestAccEMRCluster_Kerberos_clusterDedicatedKdc (508.54s)
--- PASS: TestAccEMRCluster_ebs (544.68s)
--- PASS: TestAccEMRCluster_keepJob (550.65s)
--- PASS: TestAccEMRCluster_StepConcurrency_level (551.00s)
--- PASS: TestAccEMRCluster_InstanceFleetMaster_only (563.63s)
--- PASS: TestAccEMRCluster_security (585.81s)
--- PASS: TestAccEMRCluster_CustomAMI_id (769.74s)
--- PASS: TestAccEMRCluster_terminationProtected (675.60s)
--- PASS: TestAccEMRCluster_tags (893.02s)
--- PASS: TestAccEMRCluster_RootVolume_size (919.63s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_instanceType (970.80s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_name (980.30s)
--- PASS: TestAccEMRCluster_Step_basic (983.61s)
--- PASS: TestAccEMRCluster_EC2Attributes_defaultManagedSecurityGroups (997.66s)
--- PASS: TestAccEMRCluster_Step_multiple (536.07s)
--- PASS: TestAccEMRCluster_disappears (486.32s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_name (1060.80s)
--- PASS: TestAccEMRCluster_InstanceFleet_basic (1113.99s)
--- PASS: TestAccEMRCluster_s3Logging (613.65s)
--- PASS: TestAccEMRCluster_sJSON (400.21s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_autoScalingPolicy (648.83s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_instanceCount (1217.81s)
--- PASS: TestAccEMRCluster_additionalInfo (372.52s)
--- PASS: TestAccEMRCluster_Step_mode (958.18s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_instanceType (972.02s)
--- PASS: TestAccEMRCluster_MasterInstanceGroup_bidPrice (1570.08s)
--- PASS: TestAccEMRCluster_Bootstrap_ordering (1607.18s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_instanceCount (1040.68s)
--- PASS: TestAccEMRCluster_autoTerminationPolicy (703.99s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_bidPrice (1340.46s)

[ewbankkit]

@andrei-ilyin-mh Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.