Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_cognito_user_pool_client - change lists to sets to prevent change when values are not sorted #12388

Merged
merged 1 commit into from
Mar 17, 2020
Merged

r/aws_cognito_user_pool_client - change lists to sets to prevent change when values are not sorted #12388

merged 1 commit into from
Mar 17, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #4550

Release note for CHANGELOG:

resource_aws_cognito_user_pool_client - change lists to sets to prevent change when values are not sorted

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCognitoUserPoolClient_'
--- PASS: TestAccAWSCognitoUserPoolClient_basic (52.43s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (80.58s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (80.72s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (52.45s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (79.74s)

@DrFaust92 DrFaust92 requested a review from a team March 13, 2020 20:20
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/cognito tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 13, 2020
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 17, 2020
@bflad bflad self-assigned this Mar 17, 2020
@bflad bflad added this to the v2.54.0 milestone Mar 17, 2020
@bflad bflad linked an issue Mar 17, 2020 that may be closed by this pull request
supported_identity_providers in aws_cognito_user_pool_client Ordering Causing Differences #4806
Closed
bflad
bflad approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this, @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCognitoUserPoolClient_basic (10.04s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (10.10s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (14.55s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (14.98s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (15.32s)

@bflad bflad merged commit 499aaae into hashicorp:master Mar 17, 2020
bflad added a commit that referenced this pull request Mar 17, 2020
@bflad
Update CHANGELOG for #12388
9fab667
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the cognito-client-sets branch March 22, 2020 21:43
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.54.0
2 participants
@DrFaust92 @bflad