Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_amplify_branch #11937

Merged
merged 19 commits into from
Jun 2, 2021
Merged

Conversation

k24d
Copy link
Contributor

@k24d k24d commented Feb 6, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6917

AWS Amplify service client has been merged by #9874.
Before merging this PR, #11936 must be merged. After then, I'll run git rebase for this branch.

Release note for CHANGELOG:

New Resource: aws_amplify_branch

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyBranch'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyBranch -timeout 120m
=== RUN   TestAccAWSAmplifyBranch_basic
=== PAUSE TestAccAWSAmplifyBranch_basic
=== RUN   TestAccAWSAmplifyBranch_rename
=== PAUSE TestAccAWSAmplifyBranch_rename
=== RUN   TestAccAWSAmplifyBranch_simple
=== PAUSE TestAccAWSAmplifyBranch_simple
=== RUN   TestAccAWSAmplifyBranch_backendEnvironment
=== PAUSE TestAccAWSAmplifyBranch_backendEnvironment
=== RUN   TestAccAWSAmplifyBranch_pullRequestPreview
=== PAUSE TestAccAWSAmplifyBranch_pullRequestPreview
=== RUN   TestAccAWSAmplifyBranch_basicAuthConfig
=== PAUSE TestAccAWSAmplifyBranch_basicAuthConfig
=== RUN   TestAccAWSAmplifyBranch_notification
=== PAUSE TestAccAWSAmplifyBranch_notification
=== RUN   TestAccAWSAmplifyBranch_environmentVariables
=== PAUSE TestAccAWSAmplifyBranch_environmentVariables
=== RUN   TestAccAWSAmplifyBranch_tags
=== PAUSE TestAccAWSAmplifyBranch_tags
=== CONT  TestAccAWSAmplifyBranch_basic
=== CONT  TestAccAWSAmplifyBranch_basicAuthConfig
=== CONT  TestAccAWSAmplifyBranch_tags
=== CONT  TestAccAWSAmplifyBranch_environmentVariables
=== CONT  TestAccAWSAmplifyBranch_notification
=== CONT  TestAccAWSAmplifyBranch_backendEnvironment
=== CONT  TestAccAWSAmplifyBranch_pullRequestPreview
=== CONT  TestAccAWSAmplifyBranch_simple
=== CONT  TestAccAWSAmplifyBranch_rename
--- PASS: TestAccAWSAmplifyBranch_pullRequestPreview (22.15s)
--- PASS: TestAccAWSAmplifyBranch_notification (23.90s)
--- PASS: TestAccAWSAmplifyBranch_rename (34.36s)
--- PASS: TestAccAWSAmplifyBranch_basic (41.88s)
--- PASS: TestAccAWSAmplifyBranch_environmentVariables (47.91s)
--- PASS: TestAccAWSAmplifyBranch_simple (52.51s)
--- PASS: TestAccAWSAmplifyBranch_backendEnvironment (52.77s)
--- PASS: TestAccAWSAmplifyBranch_basicAuthConfig (77.29s)
--- PASS: TestAccAWSAmplifyBranch_tags (77.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	79.278s

@k24d k24d requested a review from a team February 6, 2020 16:23
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/amplify Issues and PRs that pertain to the amplify service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 6, 2020
@teamterraform

This comment has been minimized.

Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyBranch_basic\|TestAccAWSAmplifyBranch_disappears\|TestAccAWSAmplifyBranch_Tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyBranch_basic\|TestAccAWSAmplifyBranch_disappears\|TestAccAWSAmplifyBranch_Tags -timeout 180m
=== RUN   TestAccAWSAmplifyBranch_basic
=== PAUSE TestAccAWSAmplifyBranch_basic
=== RUN   TestAccAWSAmplifyBranch_disappears
=== PAUSE TestAccAWSAmplifyBranch_disappears
=== RUN   TestAccAWSAmplifyBranch_Tags
=== PAUSE TestAccAWSAmplifyBranch_Tags
=== CONT  TestAccAWSAmplifyBranch_basic
=== CONT  TestAccAWSAmplifyBranch_Tags
=== CONT  TestAccAWSAmplifyBranch_disappears
--- PASS: TestAccAWSAmplifyBranch_disappears (13.52s)
--- PASS: TestAccAWSAmplifyBranch_basic (15.00s)
--- PASS: TestAccAWSAmplifyBranch_Tags (30.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.761s
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 1, 2021
@ewbankkit ewbankkit self-assigned this Jun 1, 2021
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/Branch
=== RUN   TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn
=== PAUSE TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn
=== CONT  TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn
--- PASS: TestAccAWSAmplify_serial (28.27s)
    --- PASS: TestAccAWSAmplify_serial/Branch (0.00s)
        --- PASS: TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn (28.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.532s
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch/BasicAuthCredentials'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch/BasicAuthCredentials -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/Branch
=== RUN   TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== PAUSE TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== CONT  TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
--- PASS: TestAccAWSAmplify_serial (38.99s)
    --- PASS: TestAccAWSAmplify_serial/Branch (0.00s)
        --- PASS: TestAccAWSAmplify_serial/Branch/BasicAuthCredentials (38.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.099s
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch/EnvironmentVariables'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch/EnvironmentVariables -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/Branch
=== RUN   TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== PAUSE TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== CONT  TestAccAWSAmplify_serial/Branch/EnvironmentVariables
--- PASS: TestAccAWSAmplify_serial (35.71s)
    --- PASS: TestAccAWSAmplify_serial/Branch (0.00s)
        --- PASS: TestAccAWSAmplify_serial/Branch/EnvironmentVariables (35.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.947s
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch/OptionalArguments'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch/OptionalArguments -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/Branch
=== RUN   TestAccAWSAmplify_serial/Branch/OptionalArguments
=== PAUSE TestAccAWSAmplify_serial/Branch/OptionalArguments
=== CONT  TestAccAWSAmplify_serial/Branch/OptionalArguments
--- PASS: TestAccAWSAmplify_serial (30.92s)
    --- PASS: TestAccAWSAmplify_serial/Branch (0.00s)
        --- PASS: TestAccAWSAmplify_serial/Branch/OptionalArguments (30.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.969s
@ewbankkit ewbankkit changed the title [WIP] New Resource: aws_amplify_branch New Resource: aws_amplify_branch Jun 2, 2021
…tArn' into 'testAccAWSAmplifyBranch_OptionalArguments'.

Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch/OptionalArguments'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch/OptionalArguments -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/Branch
=== RUN   TestAccAWSAmplify_serial/Branch/OptionalArguments
=== PAUSE TestAccAWSAmplify_serial/Branch/OptionalArguments
=== CONT  TestAccAWSAmplify_serial/Branch/OptionalArguments
--- PASS: TestAccAWSAmplify_serial (29.75s)
    --- PASS: TestAccAWSAmplify_serial/Branch (0.00s)
        --- PASS: TestAccAWSAmplify_serial/Branch/OptionalArguments (29.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.968s
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch'                  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/Branch
=== RUN   TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== PAUSE TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== RUN   TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== PAUSE TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== RUN   TestAccAWSAmplify_serial/Branch/OptionalArguments
=== PAUSE TestAccAWSAmplify_serial/Branch/OptionalArguments
=== RUN   TestAccAWSAmplify_serial/Branch/basic
=== PAUSE TestAccAWSAmplify_serial/Branch/basic
=== RUN   TestAccAWSAmplify_serial/Branch/disappears
=== PAUSE TestAccAWSAmplify_serial/Branch/disappears
=== RUN   TestAccAWSAmplify_serial/Branch/Tags
=== PAUSE TestAccAWSAmplify_serial/Branch/Tags
=== CONT  TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== CONT  TestAccAWSAmplify_serial/Branch/Tags
=== CONT  TestAccAWSAmplify_serial/Branch/disappears
=== CONT  TestAccAWSAmplify_serial/Branch/basic
=== CONT  TestAccAWSAmplify_serial/Branch/OptionalArguments
=== CONT  TestAccAWSAmplify_serial/Branch/EnvironmentVariables
--- PASS: TestAccAWSAmplify_serial (43.81s)
    --- PASS: TestAccAWSAmplify_serial/Branch (0.00s)
        --- PASS: TestAccAWSAmplify_serial/Branch/disappears (24.12s)
        --- PASS: TestAccAWSAmplify_serial/Branch/basic (26.35s)
        --- PASS: TestAccAWSAmplify_serial/Branch/OptionalArguments (35.92s)
        --- PASS: TestAccAWSAmplify_serial/Branch/EnvironmentVariables (41.93s)
        --- PASS: TestAccAWSAmplify_serial/Branch/BasicAuthCredentials (43.29s)
        --- PASS: TestAccAWSAmplify_serial/Branch/Tags (43.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.540s
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/App'   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/App -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/App
=== RUN   TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== PAUSE TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== RUN   TestAccAWSAmplify_serial/App/BuildSpec
=== PAUSE TestAccAWSAmplify_serial/App/BuildSpec
=== RUN   TestAccAWSAmplify_serial/App/Name
=== PAUSE TestAccAWSAmplify_serial/App/Name
=== RUN   TestAccAWSAmplify_serial/App/Repository
    resource_aws_amplify_app_test.go:591: Environment variable AMPLIFY_GITHUB_ACCESS_TOKEN is not set
=== RUN   TestAccAWSAmplify_serial/App/disappears
=== PAUSE TestAccAWSAmplify_serial/App/disappears
=== RUN   TestAccAWSAmplify_serial/App/Tags
=== PAUSE TestAccAWSAmplify_serial/App/Tags
=== RUN   TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== PAUSE TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== RUN   TestAccAWSAmplify_serial/App/CustomRules
=== PAUSE TestAccAWSAmplify_serial/App/CustomRules
=== RUN   TestAccAWSAmplify_serial/App/Description
=== PAUSE TestAccAWSAmplify_serial/App/Description
=== RUN   TestAccAWSAmplify_serial/App/EnvironmentVariables
=== PAUSE TestAccAWSAmplify_serial/App/EnvironmentVariables
=== RUN   TestAccAWSAmplify_serial/App/IamServiceRole
=== PAUSE TestAccAWSAmplify_serial/App/IamServiceRole
=== RUN   TestAccAWSAmplify_serial/App/basic
=== PAUSE TestAccAWSAmplify_serial/App/basic
=== CONT  TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== CONT  TestAccAWSAmplify_serial/App/CustomRules
=== CONT  TestAccAWSAmplify_serial/App/disappears
=== CONT  TestAccAWSAmplify_serial/App/Description
=== CONT  TestAccAWSAmplify_serial/App/IamServiceRole
=== CONT  TestAccAWSAmplify_serial/App/EnvironmentVariables
=== CONT  TestAccAWSAmplify_serial/App/basic
=== CONT  TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== CONT  TestAccAWSAmplify_serial/App/Name
=== CONT  TestAccAWSAmplify_serial/App/BuildSpec
=== CONT  TestAccAWSAmplify_serial/App/Tags
--- PASS: TestAccAWSAmplify_serial (61.23s)
    --- PASS: TestAccAWSAmplify_serial/App (0.00s)
        --- SKIP: TestAccAWSAmplify_serial/App/Repository (0.00s)
        --- PASS: TestAccAWSAmplify_serial/App/basic (24.02s)
        --- PASS: TestAccAWSAmplify_serial/App/disappears (26.03s)
        --- PASS: TestAccAWSAmplify_serial/App/Name (35.76s)
        --- PASS: TestAccAWSAmplify_serial/App/BuildSpec (45.22s)
        --- PASS: TestAccAWSAmplify_serial/App/Tags (45.85s)
        --- PASS: TestAccAWSAmplify_serial/App/EnvironmentVariables (46.24s)
        --- PASS: TestAccAWSAmplify_serial/App/CustomRules (49.56s)
        --- PASS: TestAccAWSAmplify_serial/App/Description (50.08s)
        --- PASS: TestAccAWSAmplify_serial/App/AutoBranchCreationConfig (59.12s)
        --- PASS: TestAccAWSAmplify_serial/App/BasicAuthCredentials (60.33s)
        --- PASS: TestAccAWSAmplify_serial/App/IamServiceRole (61.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.309s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch -timeout 180m
=== RUN   TestAccAWSAmplify_serial
=== RUN   TestAccAWSAmplify_serial/Branch
=== RUN   TestAccAWSAmplify_serial/Branch/OptionalArguments
=== PAUSE TestAccAWSAmplify_serial/Branch/OptionalArguments
=== RUN   TestAccAWSAmplify_serial/Branch/basic
=== PAUSE TestAccAWSAmplify_serial/Branch/basic
=== RUN   TestAccAWSAmplify_serial/Branch/disappears
=== PAUSE TestAccAWSAmplify_serial/Branch/disappears
=== RUN   TestAccAWSAmplify_serial/Branch/Tags
=== PAUSE TestAccAWSAmplify_serial/Branch/Tags
=== RUN   TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== PAUSE TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== RUN   TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== PAUSE TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== CONT  TestAccAWSAmplify_serial/Branch/OptionalArguments
=== CONT  TestAccAWSAmplify_serial/Branch/Tags
=== CONT  TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== CONT  TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== CONT  TestAccAWSAmplify_serial/Branch/disappears
=== CONT  TestAccAWSAmplify_serial/Branch/basic
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/Branch/OptionalArguments
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/Branch/EnvironmentVariables
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/Branch/disappears
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT  TestAccAWSAmplify_serial/Branch/Tags
    resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
--- PASS: TestAccAWSAmplify_serial (1.44s)
    --- PASS: TestAccAWSAmplify_serial/Branch (0.00s)
        --- SKIP: TestAccAWSAmplify_serial/Branch/OptionalArguments (1.44s)
        --- SKIP: TestAccAWSAmplify_serial/Branch/basic (1.44s)
        --- SKIP: TestAccAWSAmplify_serial/Branch/EnvironmentVariables (1.44s)
        --- SKIP: TestAccAWSAmplify_serial/Branch/BasicAuthCredentials (1.44s)
        --- SKIP: TestAccAWSAmplify_serial/Branch/disappears (1.44s)
        --- SKIP: TestAccAWSAmplify_serial/Branch/Tags (1.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	6.377s

@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Jun 2, 2021
@ewbankkit ewbankkit merged commit d472976 into hashicorp:main Jun 2, 2021
@github-actions github-actions bot added this to the v3.44.0 milestone Jun 2, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

This has been released in version 3.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. service/amplify Issues and PRs that pertain to the amplify service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants