Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializes WorkSpaces Directory tests #11505

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Serializes WorkSpaces Directory tests #11505

merged 2 commits into from
Jan 8, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Jan 7, 2020

Serializes the acceptance tests added in #11023, since they use a shared IAM Role.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11023

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsWorkspacesDirectory'

--- PASS: TestAccAwsWorkspacesDirectory (1217.71s)
    --- PASS: TestAccAwsWorkspacesDirectory/basic (630.88s)
    --- PASS: TestAccAwsWorkspacesDirectory/subnetIds (586.83s)

@gdavison gdavison requested a review from a team January 7, 2020 00:34
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 7, 2020
@ghost ghost added documentation Introduces or discusses updates to documentation. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 7, 2020
bflad
bflad approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as-is, although I think we should consider the service IAM Role as an outside requirement (e.g. via PreCheck) similar to DMS/EMR so we can parallelize the testing, especially if the service test suite grows. 📈

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 7, 2020
@gdavison gdavison merged commit 212df20 into master Jan 8, 2020
@gdavison gdavison deleted the t-serialize-workspaces-directory-tests branch January 8, 2020 00:00
@gdavison gdavison mentioned this pull request Jan 8, 2020
Closed
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/workspaces Issues and PRs that pertain to the workspaces service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @bflad