Added instance role ARN to GameLift fleets

[divmgl]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10800

Release note for CHANGELOG:

- resource/aws_gamelift_fleet: Add `instance_role_arn` argument [GH-10800]

Output from unit testing:

➜  terraform-provider-aws git:(master) make test
==> Checking that code complies with gofmt requirements...
go test ./... -timeout=30s -parallel=4
go: downloading github.com/aws/aws-sdk-go v1.25.31
go: extracting github.com/aws/aws-sdk-go v1.25.31
go: finding github.com/aws/aws-sdk-go v1.25.31
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
ok  	github.com/terraform-providers/terraform-provider-aws/aws	12.280s
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	(cached)
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.025s
➜  terraform-provider-aws git:(master)

I'm about to use this development version on my fleet and I'll update this ticket once I've verified this works as expected. I've been able to confirm that this works as expected and my GameLift fleet now has InstanceRoleArn assigned.

[ryndaniels]

Hi @divmgl - thanks for taking the time to submit this. Before we move forward, we'll need you to run the acceptance tests for this resource - you can do this locally by running make testacc TESTARGS="-run=TestAccAWSGameliftFleet". I'm seeing some new failures on our end when running those tests against this PR, so we want to make sure we're not introducing any test regressions with this. Could you go ahead and update this with your acceptance test output once that is passing on your end? Thanks!

[ryndaniels]

Hi @divmgl - since it's been a while since we've seen any update on this PR, we're going to go ahead and pick this up ourselves to keep things moving forward. I'm going to close this issue to consolidate discussion at the new PR #11553. We've pulled your work into that - thanks for getting this started! 🙂

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!