Docs: use aws_iam_role_policy_attachment for aws_s3_bucket example

[errriclee]

Remove last reference to aws_iam_policy_attachment to discourage using the old attachment method in favor of the newer (safer) method, even though it is safe in this example.

Using the aws_iam_policy_attachment example encourages use in other places, which can cause problems if it is a widely-used built-in policy.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Output from acceptance testing: N/A

[bflad]

This is a great suggestion, thanks @errriclee 🚀

[ghost]

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!