Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_globalaccelerator_accelerator: Add sweeper #10660

Merged
merged 1 commit into from
Nov 1, 2019
Merged

tests/resource/aws_globalaccelerator_accelerator: Add sweeper #10660

merged 1 commit into from
Nov 1, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 29, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Output from sweeper in AWS Commercial:

$ go test ./aws -v -timeout=10h -sweep=us-west-2,us-east-1 -sweep-run=aws_globalaccelerator_accelerator -sweep-allow-failures
2019/10/29 01:10:45 [DEBUG] Running Sweepers for region (us-west-2):
2019/10/29 01:10:45 [DEBUG] Running Sweeper (aws_globalaccelerator_accelerator) in region (us-west-2)
...
2019/10/29 01:10:47 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/79b92eb9-b2db-47d1-976c-15259a52c8d1
2019/10/29 01:10:48 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/a8cfdff1-a0f2-412a-9c6d-b28ebffe1138
2019/10/29 01:10:49 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/349ecdba-4490-43f7-923e-e7934fe8b363
2019/10/29 01:10:50 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/51971cbf-809b-4f2a-b62f-fc279513bf25
2019/10/29 01:10:51 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/5548abed-1c92-49ab-9a8f-87d87e543294
2019/10/29 01:10:52 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/8a897a08-13d7-45b7-a37a-bf8257a4a538
2019/10/29 01:10:53 Sweeper Tests ran successfully:
	- aws_globalaccelerator_accelerator
2019/10/29 01:10:53 [DEBUG] Running Sweepers for region (us-east-1):
2019/10/29 01:10:53 [DEBUG] Running Sweeper (aws_globalaccelerator_accelerator) in region (us-east-1)
...
2019/10/29 01:10:55 Sweeper Tests ran successfully:
	- aws_globalaccelerator_accelerator
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.625s

Output from sweeper in AWS GovCloud (US):

$ go test ./aws -v -timeout=10h -sweep=us-gov-west-1 -sweep-run=aws_globalaccelerator_accelerator -sweep-allow-failures
2019/10/29 01:11:28 [DEBUG] Running Sweepers for region (us-gov-west-1):
2019/10/29 01:11:28 [DEBUG] Running Sweeper (aws_globalaccelerator_accelerator) in region (us-gov-west-1)
...
2019/10/29 01:11:32 [WARN] Skipping Global Accelerator Accelerator sweep for us-gov-west-1: RequestError: send request failed
caused by: Post https://globalaccelerator.us-gov-west-1.amazonaws.com/: dial tcp: lookup globalaccelerator.us-gov-west-1.amazonaws.com: no such host
2019/10/29 01:11:32 Sweeper Tests ran successfully:
	- aws_globalaccelerator_accelerator
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.333s

@bflad bflad requested a review from a team October 29, 2019 05:32
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 29, 2019
@bflad
tests/resource/aws_globalaccelerator_accelerator: Add sweeper
9f5c378 
Output from sweeper in AWS Commercial:

```console
$ go test ./aws -v -timeout=10h -sweep=us-west-2,us-east-1 -sweep-run=aws_globalaccelerator_accelerator -sweep-allow-failures
2019/10/29 01:10:45 [DEBUG] Running Sweepers for region (us-west-2):
2019/10/29 01:10:45 [DEBUG] Running Sweeper (aws_globalaccelerator_accelerator) in region (us-west-2)
...
2019/10/29 01:10:47 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/79b92eb9-b2db-47d1-976c-15259a52c8d1
2019/10/29 01:10:48 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/a8cfdff1-a0f2-412a-9c6d-b28ebffe1138
2019/10/29 01:10:49 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/349ecdba-4490-43f7-923e-e7934fe8b363
2019/10/29 01:10:50 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/51971cbf-809b-4f2a-b62f-fc279513bf25
2019/10/29 01:10:51 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/5548abed-1c92-49ab-9a8f-87d87e543294
2019/10/29 01:10:52 [INFO] Deleting Global Accelerator Accelerator: arn:aws:globalaccelerator::187416307283:accelerator/8a897a08-13d7-45b7-a37a-bf8257a4a538
2019/10/29 01:10:53 Sweeper Tests ran successfully:
	- aws_globalaccelerator_accelerator
2019/10/29 01:10:53 [DEBUG] Running Sweepers for region (us-east-1):
2019/10/29 01:10:53 [DEBUG] Running Sweeper (aws_globalaccelerator_accelerator) in region (us-east-1)
...
2019/10/29 01:10:55 Sweeper Tests ran successfully:
	- aws_globalaccelerator_accelerator
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.625s
```

Output from sweeper in AWS GovCloud (US):

```console
$ go test ./aws -v -timeout=10h -sweep=us-gov-west-1 -sweep-run=aws_globalaccelerator_accelerator -sweep-allow-failures
2019/10/29 01:11:28 [DEBUG] Running Sweepers for region (us-gov-west-1):
2019/10/29 01:11:28 [DEBUG] Running Sweeper (aws_globalaccelerator_accelerator) in region (us-gov-west-1)
...
2019/10/29 01:11:32 [WARN] Skipping Global Accelerator Accelerator sweep for us-gov-west-1: RequestError: send request failed
caused by: Post https://globalaccelerator.us-gov-west-1.amazonaws.com/: dial tcp: lookup globalaccelerator.us-gov-west-1.amazonaws.com: no such host
2019/10/29 01:11:32 Sweeper Tests ran successfully:
	- aws_globalaccelerator_accelerator
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.333s
```
@bflad bflad force-pushed the t-aws_globalaccelerator_accelerator-sweeper branch from b04313e to 9f5c378 Compare October 29, 2019 17:09
ryndaniels
ryndaniels approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bflad bflad added this to the v2.35.0 milestone Nov 1, 2019
@bflad bflad merged commit 2eb6516 into master Nov 1, 2019
@bflad bflad deleted the t-aws_globalaccelerator_accelerator-sweeper branch November 1, 2019 12:46
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees
No one assigned
Labels
service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @ryndaniels