Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test refactor for SNS topic #10650

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Import test refactor for SNS topic #10650

merged 1 commit into from
Oct 29, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSSNSTopic_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSSNSTopic_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSNSTopic_basic
=== PAUSE TestAccAWSSNSTopic_basic
=== RUN   TestAccAWSSNSTopic_name
=== PAUSE TestAccAWSSNSTopic_name
=== RUN   TestAccAWSSNSTopic_namePrefix
=== PAUSE TestAccAWSSNSTopic_namePrefix
=== RUN   TestAccAWSSNSTopic_policy
=== PAUSE TestAccAWSSNSTopic_policy
=== RUN   TestAccAWSSNSTopic_withIAMRole
=== PAUSE TestAccAWSSNSTopic_withIAMRole
=== RUN   TestAccAWSSNSTopic_withFakeIAMRole
=== PAUSE TestAccAWSSNSTopic_withFakeIAMRole
=== RUN   TestAccAWSSNSTopic_withDeliveryPolicy
=== PAUSE TestAccAWSSNSTopic_withDeliveryPolicy
=== RUN   TestAccAWSSNSTopic_deliveryStatus
=== PAUSE TestAccAWSSNSTopic_deliveryStatus
=== RUN   TestAccAWSSNSTopic_encryption
=== PAUSE TestAccAWSSNSTopic_encryption
=== RUN   TestAccAWSSNSTopic_tags
=== PAUSE TestAccAWSSNSTopic_tags
=== CONT  TestAccAWSSNSTopic_basic
=== CONT  TestAccAWSSNSTopic_tags
=== CONT  TestAccAWSSNSTopic_name
=== CONT  TestAccAWSSNSTopic_withDeliveryPolicy
=== CONT  TestAccAWSSNSTopic_withIAMRole
=== CONT  TestAccAWSSNSTopic_policy
=== CONT  TestAccAWSSNSTopic_namePrefix
=== CONT  TestAccAWSSNSTopic_withFakeIAMRole
=== CONT  TestAccAWSSNSTopic_encryption
=== CONT  TestAccAWSSNSTopic_deliveryStatus
--- PASS: TestAccAWSSNSTopic_namePrefix (31.46s)
--- PASS: TestAccAWSSNSTopic_name (31.51s)
--- PASS: TestAccAWSSNSTopic_basic (31.52s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (33.20s)
--- PASS: TestAccAWSSNSTopic_policy (33.37s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (42.14s)
--- PASS: TestAccAWSSNSTopic_encryption (51.16s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (51.35s)
--- PASS: TestAccAWSSNSTopic_tags (71.51s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (137.46s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       138.996s

@ryndaniels ryndaniels requested review from bflad and a team October 28, 2019 12:55
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/sns Issues and PRs that pertain to the sns service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 28, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (test failure unrelated)

--- PASS: TestAccAWSSNSTopicSubscription_basic (15.08s)
--- PASS: TestAccAWSSNSTopic_policy (15.55s)
--- PASS: TestAccAWSSNSTopic_name (15.69s)
--- PASS: TestAccAWSSNSTopic_basic (15.86s)
--- PASS: TestAccAWSSNSTopicPolicy_basic (16.24s)
--- PASS: TestAccAWSSNSTopic_namePrefix (16.48s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (16.52s)
--- PASS: TestAccAWSSNSTopic_encryption (20.58s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (25.90s)
--- PASS: TestAccAWSSNSTopic_tags (26.19s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (26.37s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (26.57s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (27.12s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (27.92s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (33.48s)
--- FAIL: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (94.52s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (127.92s)

@bflad bflad added this to the v2.34.0 milestone Oct 28, 2019
@ryndaniels ryndaniels merged commit 4102754 into master Oct 29, 2019
@ryndaniels ryndaniels deleted the rfd-at002-sns branch October 29, 2019 09:23
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/sns Issues and PRs that pertain to the sns service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants