Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import test lintignores for API gateway resources #10618

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSAPIGatewayAccount_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayAccount_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAPIGatewayAccount_basic
=== PAUSE TestAccAWSAPIGatewayAccount_basic
=== CONT  TestAccAWSAPIGatewayAccount_basic
--- PASS: TestAccAWSAPIGatewayAccount_basic (135.55s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       137.072s

make testacc TESTARGS="-run=TestAccAWSAPIGatewayClientCertificate_"   ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayClientCertificate_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAPIGatewayClientCertificate_basic
=== PAUSE TestAccAWSAPIGatewayClientCertificate_basic
=== CONT  TestAccAWSAPIGatewayClientCertificate_basic
--- PASS: TestAccAWSAPIGatewayClientCertificate_basic (44.69s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       46.141s
make testacc TESTARGS="-run=TestAccAWSAPIGatewayDocumentationPart_"  ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayDocumentationPart_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAPIGatewayDocumentationPart_basic
=== PAUSE TestAccAWSAPIGatewayDocumentationPart_basic
=== RUN   TestAccAWSAPIGatewayDocumentationPart_method
=== PAUSE TestAccAWSAPIGatewayDocumentationPart_method
=== RUN   TestAccAWSAPIGatewayDocumentationPart_responseHeader
=== PAUSE TestAccAWSAPIGatewayDocumentationPart_responseHeader
=== CONT  TestAccAWSAPIGatewayDocumentationPart_basic
=== CONT  TestAccAWSAPIGatewayDocumentationPart_responseHeader
=== CONT  TestAccAWSAPIGatewayDocumentationPart_method
--- PASS: TestAccAWSAPIGatewayDocumentationPart_method (50.75s)
--- PASS: TestAccAWSAPIGatewayDocumentationPart_basic (81.91s)
--- PASS: TestAccAWSAPIGatewayDocumentationPart_responseHeader (146.99s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       148.380s

make testacc TESTARGS="-run=TestAccAWSAPIGatewayDocumentationVersion_"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayDocumentationVersion_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAPIGatewayDocumentationVersion_basic
=== PAUSE TestAccAWSAPIGatewayDocumentationVersion_basic
=== RUN   TestAccAWSAPIGatewayDocumentationVersion_allFields
=== PAUSE TestAccAWSAPIGatewayDocumentationVersion_allFields
=== CONT  TestAccAWSAPIGatewayDocumentationVersion_basic
=== CONT  TestAccAWSAPIGatewayDocumentationVersion_allFields
--- PASS: TestAccAWSAPIGatewayDocumentationVersion_basic (69.25s)
--- PASS: TestAccAWSAPIGatewayDocumentationVersion_allFields (100.08s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       101.626s

make testacc TESTARGS="-run=TestAccAWSAPIGatewayUsagePlan_"          ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayUsagePlan_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAPIGatewayUsagePlan_basic
=== PAUSE TestAccAWSAPIGatewayUsagePlan_basic
=== RUN   TestAccAWSAPIGatewayUsagePlan_description
=== PAUSE TestAccAWSAPIGatewayUsagePlan_description
=== RUN   TestAccAWSAPIGatewayUsagePlan_productCode
=== PAUSE TestAccAWSAPIGatewayUsagePlan_productCode
=== RUN   TestAccAWSAPIGatewayUsagePlan_throttling
=== PAUSE TestAccAWSAPIGatewayUsagePlan_throttling
=== RUN   TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit
=== PAUSE TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit
=== RUN   TestAccAWSAPIGatewayUsagePlan_quota
=== PAUSE TestAccAWSAPIGatewayUsagePlan_quota
=== RUN   TestAccAWSAPIGatewayUsagePlan_apiStages
=== PAUSE TestAccAWSAPIGatewayUsagePlan_apiStages
=== CONT  TestAccAWSAPIGatewayUsagePlan_basic
=== CONT  TestAccAWSAPIGatewayUsagePlan_apiStages
=== CONT  TestAccAWSAPIGatewayUsagePlan_throttling
=== CONT  TestAccAWSAPIGatewayUsagePlan_quota
=== CONT  TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit
=== CONT  TestAccAWSAPIGatewayUsagePlan_productCode
=== CONT  TestAccAWSAPIGatewayUsagePlan_description
--- PASS: TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit (88.78s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_basic (121.68s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_apiStages (243.98s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_productCode (282.32s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_throttling (343.19s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_description (362.30s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_quota (408.78s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       410.338s

make testacc TESTARGS="-run=TestAccAWSAPIGatewayVpcLink_"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayVpcLink_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAPIGatewayVpcLink_basic
=== PAUSE TestAccAWSAPIGatewayVpcLink_basic
=== CONT  TestAccAWSAPIGatewayVpcLink_basic
--- PASS: TestAccAWSAPIGatewayVpcLink_basic (802.11s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       803.544s

@ryndaniels ryndaniels requested review from bflad and a team October 24, 2019 08:37
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 24, 2019
@bflad bflad self-assigned this Oct 25, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSAPIGatewayClientCertificate_basic (15.34s)
--- PASS: TestAccAWSAPIGatewayDocumentationVersion_basic (19.82s)
--- PASS: TestAccAWSAPIGatewayDocumentationPart_method (48.84s)
--- PASS: TestAccAWSAPIGatewayAccount_basic (76.64s)
--- PASS: TestAccAWSAPIGatewayDocumentationPart_responseHeader (80.00s)
--- PASS: TestAccAWSAPIGatewayDocumentationVersion_allFields (104.21s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_quota (137.78s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit (197.79s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_basic (200.83s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_description (231.23s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_productCode (305.22s)
--- PASS: TestAccAWSAPIGatewayUsagePlanKey_basic (354.67s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_apiStages (409.37s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_throttling (464.87s)
--- PASS: TestAccAWSAPIGatewayVpcLink_basic (674.28s)
--- PASS: TestAccAWSAPIGatewayDocumentationPart_basic (698.51s)

@bflad bflad added this to the v2.34.0 milestone Oct 25, 2019
@ryndaniels ryndaniels merged commit 1c3d76f into master Oct 29, 2019
@ryndaniels ryndaniels deleted the rfd-at002-apigw branch October 29, 2019 09:21
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants