Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test refactor for cloudy resources #10607

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

  • NOTE: TestAccAWSCloud9EnvironmentEc2_basic timeout failure is not new
$ make testacc TESTARGS="-run=TestAccAWSCloud9EnvironmentEc2_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCloud9EnvironmentEc2_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCloud9EnvironmentEc2_basic
=== PAUSE TestAccAWSCloud9EnvironmentEc2_basic
=== RUN   TestAccAWSCloud9EnvironmentEc2_allFields
=== PAUSE TestAccAWSCloud9EnvironmentEc2_allFields
=== CONT  TestAccAWSCloud9EnvironmentEc2_basic
=== CONT  TestAccAWSCloud9EnvironmentEc2_allFields
--- PASS: TestAccAWSCloud9EnvironmentEc2_allFields (393.15s)
--- FAIL: TestAccAWSCloud9EnvironmentEc2_basic (670.74s)
    testing.go:569: Step 0 error: errors during apply:
        
        Error: timeout while waiting for state to become 'ready' (last state: 'connecting', timeout: 10m0s)
        
          on /var/folders/pd/swwl85ks1nvbfy2pht84q2m40000gq/T/tf-test817560255/main.tf line 2:
          (source code not available)
        
        
FAIL
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       672.157s

make testacc TESTARGS="-run=TestAccAWSCloudFormationStack_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCloudFormationStack_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCloudFormationStack_dataSource_basic
=== PAUSE TestAccAWSCloudFormationStack_dataSource_basic
=== RUN   TestAccAWSCloudFormationStack_dataSource_yaml
=== PAUSE TestAccAWSCloudFormationStack_dataSource_yaml
=== RUN   TestAccAWSCloudFormationStack_basic
=== PAUSE TestAccAWSCloudFormationStack_basic
=== RUN   TestAccAWSCloudFormationStack_disappears
=== PAUSE TestAccAWSCloudFormationStack_disappears
=== RUN   TestAccAWSCloudFormationStack_yaml
=== PAUSE TestAccAWSCloudFormationStack_yaml
=== RUN   TestAccAWSCloudFormationStack_defaultParams
=== PAUSE TestAccAWSCloudFormationStack_defaultParams
=== RUN   TestAccAWSCloudFormationStack_allAttributes
=== PAUSE TestAccAWSCloudFormationStack_allAttributes
=== RUN   TestAccAWSCloudFormationStack_withParams
=== PAUSE TestAccAWSCloudFormationStack_withParams
=== RUN   TestAccAWSCloudFormationStack_withUrl_withParams
=== PAUSE TestAccAWSCloudFormationStack_withUrl_withParams
=== RUN   TestAccAWSCloudFormationStack_withUrl_withParams_withYaml
=== PAUSE TestAccAWSCloudFormationStack_withUrl_withParams_withYaml
=== RUN   TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate
=== PAUSE TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate
=== CONT  TestAccAWSCloudFormationStack_dataSource_basic
=== CONT  TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate
=== CONT  TestAccAWSCloudFormationStack_defaultParams
=== CONT  TestAccAWSCloudFormationStack_yaml
=== CONT  TestAccAWSCloudFormationStack_withParams
=== CONT  TestAccAWSCloudFormationStack_dataSource_yaml
=== CONT  TestAccAWSCloudFormationStack_basic
=== CONT  TestAccAWSCloudFormationStack_withUrl_withParams_withYaml
=== CONT  TestAccAWSCloudFormationStack_disappears
=== CONT  TestAccAWSCloudFormationStack_allAttributes
=== CONT  TestAccAWSCloudFormationStack_withUrl_withParams
--- PASS: TestAccAWSCloudFormationStack_yaml (79.62s)
--- PASS: TestAccAWSCloudFormationStack_basic (83.72s)
--- PASS: TestAccAWSCloudFormationStack_disappears (84.29s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (90.30s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (93.53s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (94.87s)
--- PASS: TestAccAWSCloudFormationStack_allAttributes (117.79s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (135.99s)
--- PASS: TestAccAWSCloudFormationStack_withParams (151.23s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (193.45s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (235.66s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       237.198s

make testacc TESTARGS="-run=TestAccAWSCloudFrontOriginAccessIdentity_"    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontOriginAccessIdentity_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCloudFrontOriginAccessIdentity_basic
=== PAUSE TestAccAWSCloudFrontOriginAccessIdentity_basic
=== RUN   TestAccAWSCloudFrontOriginAccessIdentity_noComment
=== PAUSE TestAccAWSCloudFrontOriginAccessIdentity_noComment
=== CONT  TestAccAWSCloudFrontOriginAccessIdentity_basic
=== CONT  TestAccAWSCloudFrontOriginAccessIdentity_noComment
--- PASS: TestAccAWSCloudFrontOriginAccessIdentity_basic (25.98s)
--- PASS: TestAccAWSCloudFrontOriginAccessIdentity_noComment (26.29s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       27.718s

@ryndaniels ryndaniels requested review from bflad and a team October 23, 2019 13:18
@ghost ghost added service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. size/L Managed by automation to categorize the size of a PR. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 23, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

--- PASS: TestAccAWSCloudFormationStackSet_Description (51.14s)                                                                               
--- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (54.91s)                                                                     
--- PASS: TestAccAWSCloudFormationStack_basic (69.00s)                                                                                        
--- PASS: TestAccAWSCloudFormationStackSet_Parameters (73.05s)                                                                                
--- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (74.01s)                                                                               
--- PASS: TestAccAWSCloudFormationStack_disappears (74.59s)                                                                                   
--- PASS: TestAccAWSCloudFormationStack_importBasic (77.38s)                                                                                  
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (81.89s)   
--- PASS: TestAccAWSCloudFormationStack_allAttributes (91.33s)
--- PASS: TestAccAWSCloudFormationStackSet_Tags (93.52s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (97.90s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (70.54s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (76.03s)
--- PASS: TestAccAWSCloudFormationStack_yaml (80.59s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (127.07s)
--- PASS: TestAccAWSCloudFormationStack_withParams (153.60s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (182.66s)

@bflad bflad added this to the v2.34.0 milestone Oct 28, 2019
@ryndaniels ryndaniels merged commit 65529d2 into master Oct 29, 2019
@ryndaniels ryndaniels deleted the rfd-at002-clouds branch October 29, 2019 09:20
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants