Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test refactor for codecommit #10604

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Import test refactor for codecommit #10604

merged 1 commit into from
Oct 29, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSCodeCommitRepository_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCodeCommitRepository_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCodeCommitRepository_basic
=== PAUSE TestAccAWSCodeCommitRepository_basic
=== RUN   TestAccAWSCodeCommitRepository_withChanges
=== PAUSE TestAccAWSCodeCommitRepository_withChanges
=== RUN   TestAccAWSCodeCommitRepository_create_default_branch
=== PAUSE TestAccAWSCodeCommitRepository_create_default_branch
=== RUN   TestAccAWSCodeCommitRepository_create_and_update_default_branch
=== PAUSE TestAccAWSCodeCommitRepository_create_and_update_default_branch
=== RUN   TestAccAWSCodeCommitRepository_tags
=== PAUSE TestAccAWSCodeCommitRepository_tags
=== CONT  TestAccAWSCodeCommitRepository_basic
=== CONT  TestAccAWSCodeCommitRepository_create_and_update_default_branch
=== CONT  TestAccAWSCodeCommitRepository_tags
=== CONT  TestAccAWSCodeCommitRepository_create_default_branch
=== CONT  TestAccAWSCodeCommitRepository_withChanges
--- PASS: TestAccAWSCodeCommitRepository_basic (32.06s)
--- PASS: TestAccAWSCodeCommitRepository_create_default_branch (32.88s)
--- PASS: TestAccAWSCodeCommitRepository_create_and_update_default_branch (51.51s)
--- PASS: TestAccAWSCodeCommitRepository_withChanges (52.00s)
--- PASS: TestAccAWSCodeCommitRepository_tags (71.76s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       73.200s

@ryndaniels ryndaniels requested review from bflad and a team October 23, 2019 09:03
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/codecommit Issues and PRs that pertain to the codecommit service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 23, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@bflad bflad added this to the v2.34.0 milestone Oct 28, 2019
@ryndaniels ryndaniels merged commit 7b96d4f into master Oct 29, 2019
@ryndaniels ryndaniels deleted the rfd-at002-codecommit branch October 29, 2019 09:18
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/codecommit Issues and PRs that pertain to the codecommit service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants