add error handling for when bucket is already destroyed

[teraken0509]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10492

Release note for CHANGELOG:

NONE

Output from acceptance testing:

ter *)$ make testacc TESTARGS='-run=TestAccAWSS3BucketPublicAccessBlock_bucketDisappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSS3BucketPublicAccessBlock_bucketDisappears -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSS3BucketPublicAccessBlock_bucketDisappears
=== PAUSE TestAccAWSS3BucketPublicAccessBlock_bucketDisappears
=== CONT  TestAccAWSS3BucketPublicAccessBlock_bucketDisappears
--- PASS: TestAccAWSS3BucketPublicAccessBlock_bucketDisappears (35.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.954s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.013s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.025s [no tests to run]

[bflad]

Thanks so much for this fix, @kterada0509 🚀

--- PASS: TestAccAWSS3BucketPublicAccessBlock_basic (34.92s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicAcls (67.96s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicPolicy (65.97s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_bucketDisappears (18.88s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_disappears (29.57s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_IgnorePublicAcls (64.78s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_RestrictPublicBuckets (63.24s)

[ghost]

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!