Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WAF Web ACL and Rule data source docs #10504

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Update WAF Web ACL and Rule data source docs #10504

merged 1 commit into from
Oct 30, 2019

Conversation

diogoazevedos
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. labels Oct 14, 2019
@diogoazevedos diogoazevedos marked this pull request as ready for review October 16, 2019 14:24
@diogoazevedos diogoazevedos requested a review from a team October 16, 2019 14:24
aeschright
aeschright approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up! 👍

@aeschright aeschright merged commit 8ccb1d4 into hashicorp:master Oct 30, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diogoazevedos @aeschright