-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tag Support for aws_waf_rate_based_rule resource #10479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be good to go with one optimization, thanks @DrFaust92 🎉
re-use arn attribute Co-Authored-By: Brian Flad <bflad417@gmail.com>
rate based rule create function calls read and not update
rate based rule create function calls read and not update
use generated function in code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @DrFaust92 🚀
--- PASS: TestAccAWSWafRateBasedRule_noPredicates (18.39s)
--- PASS: TestAccAWSWafRateBasedRule_basic (43.32s)
--- PASS: TestAccAWSWafRateBasedRule_disappears (46.17s)
--- PASS: TestAccAWSWafRateBasedRule_changePredicates (69.26s)
--- PASS: TestAccAWSWafRateBasedRule_Tags (75.38s)
--- PASS: TestAccAWSWafRateBasedRule_changeNameForceNew (94.17s)
@@ -286,6 +289,8 @@ func ServiceListTagsInputResourceTypeField(serviceName string) string { | |||
// ServiceListTagsOutputTagsField determines the service tag field. | |||
func ServiceListTagsOutputTagsField(serviceName string) string { | |||
switch serviceName { | |||
case "waf": | |||
return "TagInfoForResource.TagList" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
return conn.CreateRateBasedRule(params) | ||
}) | ||
if err != nil { | ||
return err | ||
} | ||
resp := out.(*waf.CreateRateBasedRuleOutput) | ||
d.SetId(*resp.Rule.RuleId) | ||
return resourceAwsWafRateBasedRuleUpdate(d, meta) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates to #9289
Release note for CHANGELOG:
Output from acceptance testing: