Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance test import refactor for dynamodb resources #10433

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Acceptance test import refactor for dynamodb resources #10433

merged 1 commit into from
Oct 10, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

NOTE: the one test failure is not new

$ make testacc TESTARGS="-run=TestAccAWSDynamoDbTable_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDynamoDbTable_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDynamoDbTable_basic
=== PAUSE TestAccAWSDynamoDbTable_basic
=== RUN   TestAccAWSDynamoDbTable_disappears
=== PAUSE TestAccAWSDynamoDbTable_disappears
=== RUN   TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI
=== PAUSE TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI
=== RUN   TestAccAWSDynamoDbTable_extended
=== PAUSE TestAccAWSDynamoDbTable_extended
=== RUN   TestAccAWSDynamoDbTable_enablePitr
=== PAUSE TestAccAWSDynamoDbTable_enablePitr
=== RUN   TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned
=== PAUSE TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned
=== RUN   TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest
=== PAUSE TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest
=== RUN   TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned
=== PAUSE TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned
=== RUN   TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest
=== PAUSE TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest
=== RUN   TestAccAWSDynamoDbTable_streamSpecification
=== PAUSE TestAccAWSDynamoDbTable_streamSpecification
=== RUN   TestAccAWSDynamoDbTable_streamSpecificationValidation
=== PAUSE TestAccAWSDynamoDbTable_streamSpecificationValidation
=== RUN   TestAccAWSDynamoDbTable_tags
=== PAUSE TestAccAWSDynamoDbTable_tags
=== RUN   TestAccAWSDynamoDbTable_gsiUpdateCapacity
=== PAUSE TestAccAWSDynamoDbTable_gsiUpdateCapacity
=== RUN   TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes
=== PAUSE TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes
=== RUN   TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes
=== PAUSE TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes
=== RUN   TestAccAWSDynamoDbTable_Ttl_Enabled
=== PAUSE TestAccAWSDynamoDbTable_Ttl_Enabled
=== RUN   TestAccAWSDynamoDbTable_Ttl_Disabled
=== PAUSE TestAccAWSDynamoDbTable_Ttl_Disabled
=== RUN   TestAccAWSDynamoDbTable_attributeUpdate
=== PAUSE TestAccAWSDynamoDbTable_attributeUpdate
=== RUN   TestAccAWSDynamoDbTable_attributeUpdateValidation
=== PAUSE TestAccAWSDynamoDbTable_attributeUpdateValidation
=== RUN   TestAccAWSDynamoDbTable_encryption
=== PAUSE TestAccAWSDynamoDbTable_encryption
=== CONT  TestAccAWSDynamoDbTable_basic
=== CONT  TestAccAWSDynamoDbTable_encryption
=== CONT  TestAccAWSDynamoDbTable_tags
=== CONT  TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest
=== CONT  TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned
=== CONT  TestAccAWSDynamoDbTable_attributeUpdateValidation
=== CONT  TestAccAWSDynamoDbTable_attributeUpdate
=== CONT  TestAccAWSDynamoDbTable_Ttl_Disabled
=== CONT  TestAccAWSDynamoDbTable_Ttl_Enabled
=== CONT  TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes
=== CONT  TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes
=== CONT  TestAccAWSDynamoDbTable_gsiUpdateCapacity
=== CONT  TestAccAWSDynamoDbTable_enablePitr
=== CONT  TestAccAWSDynamoDbTable_extended
=== CONT  TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI
=== CONT  TestAccAWSDynamoDbTable_disappears
=== CONT  TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned
=== CONT  TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest
=== CONT  TestAccAWSDynamoDbTable_streamSpecificationValidation
=== CONT  TestAccAWSDynamoDbTable_streamSpecification
--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (8.63s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (10.94s)
--- PASS: TestAccAWSDynamoDbTable_disappears (33.30s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (73.15s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (124.00s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (142.24s)
--- PASS: TestAccAWSDynamoDbTable_basic (144.69s)
--- PASS: TestAccAWSDynamoDbTable_tags (147.83s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (169.53s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (178.91s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (190.54s)
--- PASS: TestAccAWSDynamoDbTable_encryption (199.27s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (224.27s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (349.77s)
--- PASS: TestAccAWSDynamoDbTable_extended (445.29s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (445.82s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (749.13s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (750.78s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (1044.95s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (1370.28s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1372.854s

make testacc TESTARGS="-run=TestAccAWSDynamoDbGlobalTable_"           ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDynamoDbGlobalTable_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDynamoDbGlobalTable_basic
=== PAUSE TestAccAWSDynamoDbGlobalTable_basic
=== RUN   TestAccAWSDynamoDbGlobalTable_multipleRegions
=== PAUSE TestAccAWSDynamoDbGlobalTable_multipleRegions
=== CONT  TestAccAWSDynamoDbGlobalTable_basic
=== CONT  TestAccAWSDynamoDbGlobalTable_multipleRegions
--- FAIL: TestAccAWSDynamoDbGlobalTable_multipleRegions (134.62s)
    testing.go:630: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: errors during apply: error deleting DynamoDB Table (tf-acc-test-162jy): Error deleting DynamoDB table: ResourceNotFoundException: Requested resource not found: Table: tf-acc-test-162jy not found
                status code: 400, request id: TUDQUH482J1F8US16DDJ97QD4BVV4KQNSO5AEMVJF66Q9ASUAAJG
        
        State: aws_dynamodb_table.us-west-2:
          ID = tf-acc-test-162jy
          provider = provider.aws.us-west-2
          arn = arn:aws:dynamodb:us-west-2:187416307283:table/tf-acc-test-162jy
          attribute.# = 1
          attribute.1507348186.name = myAttribute
          attribute.1507348186.type = S
          billing_mode = PROVISIONED
          global_secondary_index.# = 0
          hash_key = myAttribute
          local_secondary_index.# = 0
          name = tf-acc-test-162jy
          point_in_time_recovery.# = 1
          point_in_time_recovery.0.enabled = false
          read_capacity = 1
          server_side_encryption.# = 0
          stream_arn = arn:aws:dynamodb:us-west-2:187416307283:table/tf-acc-test-162jy/stream/2019-10-09T11:21:35.448
          stream_enabled = true
          stream_label = 2019-10-09T11:21:35.448
          stream_view_type = NEW_AND_OLD_IMAGES
          tags.% = 0
          ttl.# = 1
          ttl.0.attribute_name = 
          ttl.0.enabled = false
          write_capacity = 1
--- PASS: TestAccAWSDynamoDbGlobalTable_basic (199.37s)
FAIL
FAIL    github.com/terraform-providers/terraform-provider-aws/aws       200.306s

@ryndaniels ryndaniels requested review from bflad and a team October 9, 2019 12:17
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/dynamodb Issues and PRs that pertain to the dynamodb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 9, 2019
bflad
bflad approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSDynamoDbTable_streamSpecificationValidation (8.60s)
--- PASS: TestAccAWSDynamoDbTableItem_withMultipleItems (21.19s)
--- PASS: TestAccAWSDynamoDbTable_disappears (21.90s)
--- PASS: TestAccAWSDynamoDbTableItem_rangeKey (22.56s)
--- PASS: TestAccAWSDynamoDbTable_tags (29.74s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Enabled (16.50s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdateValidation (3.51s)
--- PASS: TestAccAWSDynamoDbTableItem_basic (108.51s)
--- PASS: TestAccAWSDynamoDbTable_basic (113.25s)
--- PASS: TestAccAWSDynamoDbTableItem_update (117.99s)
--- PASS: TestAccAWSDynamoDbTableItem_updateWithRangeKey (118.47s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_PayPerRequestToProvisioned (126.11s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_PayPerRequestToProvisioned (131.91s)
--- PASS: TestAccAWSDynamoDbTable_Ttl_Disabled (112.99s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (140.24s)
--- PASS: TestAccAWSDynamoDbTable_streamSpecification (167.61s)
--- PASS: TestAccAWSDynamoDbTable_encryption (215.80s)
--- PASS: TestAccAWSDynamoDbTable_enablePitr (301.88s)
--- PASS: TestAccAWSDynamoDbGlobalTable_basic (313.08s)
--- PASS: TestAccAWSDynamoDbTable_extended (358.30s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (375.42s)
--- PASS: TestAccAWSDynamoDbTable_disappears_PayPerRequestWithGSI (408.66s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_ProvisionedToPayPerRequest (662.13s)
--- PASS: TestAccAWSDynamoDbTable_attributeUpdate (665.34s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (692.53s)
--- PASS: TestAccAWSDynamoDbTable_BillingMode_GSI_ProvisionedToPayPerRequest (890.93s)

@bflad bflad added this to the v2.32.0 milestone Oct 10, 2019
@bflad bflad merged commit 8f487f2 into master Oct 10, 2019
@bflad bflad deleted the rfd-at002-dynamodb branch October 10, 2019 14:21
@ghost
Copy link

ghost commented Oct 10, 2019

This has been released in version 2.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 9, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
service/dynamodb Issues and PRs that pertain to the dynamodb service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad