Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore lint complaints for valid fsx lustre fs tests #10101

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSFsxLustreFileSystem_"          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSFsxLustreFileSystem_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_disappears
=== PAUSE TestAccAWSFsxLustreFileSystem_disappears
=== RUN   TestAccAWSFsxLustreFileSystem_ExportPath
=== PAUSE TestAccAWSFsxLustreFileSystem_ExportPath
=== RUN   TestAccAWSFsxLustreFileSystem_ImportPath
=== PAUSE TestAccAWSFsxLustreFileSystem_ImportPath
=== RUN   TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize
=== PAUSE TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize
=== RUN   TestAccAWSFsxLustreFileSystem_SecurityGroupIds
=== PAUSE TestAccAWSFsxLustreFileSystem_SecurityGroupIds
=== RUN   TestAccAWSFsxLustreFileSystem_StorageCapacity
=== PAUSE TestAccAWSFsxLustreFileSystem_StorageCapacity
=== RUN   TestAccAWSFsxLustreFileSystem_Tags
=== PAUSE TestAccAWSFsxLustreFileSystem_Tags
=== RUN   TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime
=== PAUSE TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime
=== CONT  TestAccAWSFsxLustreFileSystem_disappears
=== CONT  TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize
=== CONT  TestAccAWSFsxLustreFileSystem_Tags
=== CONT  TestAccAWSFsxLustreFileSystem_StorageCapacity
=== CONT  TestAccAWSFsxLustreFileSystem_SecurityGroupIds
=== CONT  TestAccAWSFsxLustreFileSystem_ImportPath
=== CONT  TestAccAWSFsxLustreFileSystem_ExportPath
--- PASS: TestAccAWSFsxLustreFileSystem_disappears (449.44s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (482.43s)
--- PASS: TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime (549.72s)
--- PASS: TestAccAWSFsxLustreFileSystem_Tags (608.41s)
--- PASS: TestAccAWSFsxLustreFileSystem_SecurityGroupIds (969.75s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (971.78s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize (1110.86s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportPath (1124.92s)
--- PASS: TestAccAWSFsxLustreFileSystem_ExportPath (1252.05s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1254.359s

@ryndaniels ryndaniels requested review from aeschright and a team September 13, 2019 12:00
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 13, 2019
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--- PASS: TestAccAWSFsxLustreFileSystem_basic (420.26s)
--- PASS: TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime (421.29s)
--- PASS: TestAccAWSFsxLustreFileSystem_Tags (422.39s)
--- PASS: TestAccAWSFsxLustreFileSystem_disappears (429.92s)
--- PASS: TestAccAWSFsxLustreFileSystem_SecurityGroupIds (798.58s)
--- PASS: TestAccAWSFsxLustreFileSystem_ExportPath (861.95s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (942.43s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportPath (994.58s)
--- PASS: TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize (1043.30s)

@ryndaniels ryndaniels merged commit ed7a47f into master Sep 17, 2019
@nywilken nywilken added this to the v2.29.0 milestone Sep 20, 2019
@ghost
Copy link

ghost commented Sep 20, 2019

This has been released in version 2.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
@bflad bflad deleted the rfd-at002-fsx branch April 23, 2020 03:38
@breathingdust breathingdust added the linter Pertains to changes to or issues with the various linters. label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter Pertains to changes to or issues with the various linters. service/fsx Issues and PRs that pertain to the fsx service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants