Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test refactor for glue catalog resources #10077

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSGlueCatalogTable_"
==> Fixing source code with gofmt...
gofmt -s -w ./aws
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSGlueCatalogTable_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSGlueCatalogTable_recreates
=== PAUSE TestAccAWSGlueCatalogTable_recreates
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_recreates
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGlueCatalogTable_basic
--- PASS: TestAccAWSGlueCatalogTable_basic (31.78s)
--- PASS: TestAccAWSGlueCatalogTable_full (33.81s)
--- PASS: TestAccAWSGlueCatalogTable_recreates (39.39s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (50.92s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (51.08s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       57.765s

make testacc TESTARGS="-run=TestAccAWSGlueCatalogDatabase_"
==> Fixing source code with gofmt...
gofmt -s -w ./aws
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSGlueCatalogDatabase_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSGlueCatalogDatabase_full
=== PAUSE TestAccAWSGlueCatalogDatabase_full
=== RUN   TestAccAWSGlueCatalogDatabase_recreates
=== PAUSE TestAccAWSGlueCatalogDatabase_recreates
=== CONT  TestAccAWSGlueCatalogDatabase_full
=== CONT  TestAccAWSGlueCatalogDatabase_recreates
--- PASS: TestAccAWSGlueCatalogDatabase_recreates (30.10s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (68.12s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       74.722s

@ryndaniels ryndaniels requested review from aeschright and a team September 11, 2019 14:53
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 11, 2019
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@ryndaniels ryndaniels merged commit 62d5318 into master Sep 19, 2019
@ryndaniels ryndaniels deleted the rfd-at002-glue branch September 19, 2019 09:54
@nywilken nywilken added this to the v2.29.0 milestone Sep 20, 2019
@ghost
Copy link

ghost commented Sep 20, 2019

This has been released in version 2.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants