Add aws.StringValue wrapper to prevent crash on missing environment name

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10065

Release note for CHANGELOG:

BUG FIXES:
* ecs_task_definition_equivalency: Fix a crash if environment name is missing

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAwsEcsContainerDefinitionsAreEquivalent_"
==> Fixing source code with gofmt...
gofmt -s -w ./aws
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAwsEcsContainerDefinitionsAreEquivalent_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_basic
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_basic (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_portMappings
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_portMappings (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_portMappingsIgnoreHostPort
2019/09/11 13:53:20 [DEBUG] Canonical definitions are not equal.
First: [{"essential":true,"image":"wordpress","name":"wordpress","portMappings":[{"containerPort":80,"hostPort":80}]}]
Second: [{"essential":true,"image":"wordpress","name":"wordpress","portMappings":[{"containerPort":80}]}]
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_portMappingsIgnoreHostPort (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_arrays
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_arrays (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_negative
2019/09/11 13:53:20 [DEBUG] Canonical definitions are not equal.
First: [{"cpu":10,"environment":[{"name":"EXAMPLE_NAME","value":"foobar"}],"essential":true,"image":"wordpress","memory":500,"name":"wordpress"}]
Second: [{"cpu":10,"essential":true,"image":"wordpress","memory":500,"name":"wordpress"}]
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_negative (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws

[bflad]

Can you please add a covering unit test to prevent future regressions? Thanks so much. 👍

[ryndaniels]

Updated test output:

make testacc TESTARGS="-run=TestAwsEcsContainerDefinitionsAreEquivalent_"                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAwsEcsContainerDefinitionsAreEquivalent_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_basic
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_basic (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_portMappings
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_portMappings (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_portMappingsIgnoreHostPort
2019/09/12 12:53:43 [DEBUG] Canonical definitions are not equal.
First: [{"essential":true,"image":"wordpress","name":"wordpress","portMappings":[{"containerPort":80,"hostPort":80}]}]
Second: [{"essential":true,"image":"wordpress","name":"wordpress","portMappings":[{"containerPort":80}]}]
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_portMappingsIgnoreHostPort (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_arrays
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_arrays (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_negative
2019/09/12 12:53:43 [DEBUG] Canonical definitions are not equal.
First: [{"cpu":10,"environment":[{"name":"EXAMPLE_NAME","value":"foobar"}],"essential":true,"image":"wordpress","memory":500,"name":"wordpress"}]
Second: [{"cpu":10,"essential":true,"image":"wordpress","memory":500,"name":"wordpress"}]
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_negative (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_missingEnvironmentName
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_missingEnvironmentName (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1.087s

[nywilken]

LGTM 👍 👍

--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_missingEnvironmentName

[ghost]

This has been released in version 2.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!