Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor import testing for KMS resources #10043

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Refactor import testing for KMS resources #10043

merged 1 commit into from
Sep 24, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$  make testacc TESTARGS="-run=TestAccAWSKmsKey_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSKmsKey_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSKmsKey_basic
=== PAUSE TestAccAWSKmsKey_basic
=== RUN   TestAccAWSKmsKey_disappears
=== PAUSE TestAccAWSKmsKey_disappears
=== RUN   TestAccAWSKmsKey_policy
=== PAUSE TestAccAWSKmsKey_policy
=== RUN   TestAccAWSKmsKey_isEnabled
=== PAUSE TestAccAWSKmsKey_isEnabled
=== RUN   TestAccAWSKmsKey_tags
=== PAUSE TestAccAWSKmsKey_tags
=== CONT  TestAccAWSKmsKey_basic
=== CONT  TestAccAWSKmsKey_tags
=== CONT  TestAccAWSKmsKey_disappears
=== CONT  TestAccAWSKmsKey_policy
=== CONT  TestAccAWSKmsKey_isEnabled
--- PASS: TestAccAWSKmsKey_disappears (32.72s)
--- PASS: TestAccAWSKmsKey_tags (64.73s)
--- PASS: TestAccAWSKmsKey_policy (66.53s)
--- PASS: TestAccAWSKmsKey_basic (88.55s)
--- PASS: TestAccAWSKmsKey_isEnabled (444.36s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       446.421s

make testacc TESTARGS="-run=TestAccAWSKmsAlias_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSKmsAlias_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSKmsAlias_basic
=== PAUSE TestAccAWSKmsAlias_basic
=== RUN   TestAccAWSKmsAlias_name_prefix
=== PAUSE TestAccAWSKmsAlias_name_prefix
=== RUN   TestAccAWSKmsAlias_no_name
=== PAUSE TestAccAWSKmsAlias_no_name
=== RUN   TestAccAWSKmsAlias_multiple
=== PAUSE TestAccAWSKmsAlias_multiple
=== RUN   TestAccAWSKmsAlias_ArnDiffSuppress
=== PAUSE TestAccAWSKmsAlias_ArnDiffSuppress
=== CONT  TestAccAWSKmsAlias_basic
=== CONT  TestAccAWSKmsAlias_ArnDiffSuppress
=== CONT  TestAccAWSKmsAlias_multiple
=== CONT  TestAccAWSKmsAlias_no_name
=== CONT  TestAccAWSKmsAlias_name_prefix
--- PASS: TestAccAWSKmsAlias_multiple (65.63s)
--- PASS: TestAccAWSKmsAlias_name_prefix (65.79s)
--- PASS: TestAccAWSKmsAlias_no_name (65.85s)
--- PASS: TestAccAWSKmsAlias_ArnDiffSuppress (85.97s)
--- PASS: TestAccAWSKmsAlias_basic (91.28s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       92.454s

@ryndaniels ryndaniels requested review from aeschright and a team September 9, 2019 11:57
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 9, 2019
@bflad bflad self-assigned this Sep 24, 2019
@bflad bflad added this to the v2.30.0 milestone Sep 24, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSKmsKey_disappears (13.04s)
--- PASS: TestAccAWSKmsAlias_no_name (28.42s)
--- PASS: TestAccAWSKmsAlias_multiple (30.42s)
--- PASS: TestAccAWSKmsKey_policy (30.57s)
--- PASS: TestAccAWSKmsAlias_name_prefix (30.93s)
--- PASS: TestAccAWSKmsKey_tags (30.97s)
--- PASS: TestAccAWSKmsAlias_ArnDiffSuppress (34.03s)
--- PASS: TestAccAWSKmsAlias_basic (34.62s)
--- PASS: TestAccAWSKmsKey_basic (34.94s)
--- PASS: TestAccAWSKmsKey_isEnabled (190.14s)

@bflad bflad merged commit 37dad35 into master Sep 24, 2019
@bflad bflad deleted the rfd-at002-kms-only branch September 24, 2019 11:21
@ghost
Copy link

ghost commented Sep 26, 2019

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/kms Issues and PRs that pertain to the kms service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants