Acceptance test import refactor for network acls

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSNetworkAcl"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSNetworkAcl -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSNetworkAclRule_basic
=== PAUSE TestAccAWSNetworkAclRule_basic
=== RUN   TestAccAWSNetworkAclRule_disappears
=== PAUSE TestAccAWSNetworkAclRule_disappears
=== RUN   TestAccAWSNetworkAclRule_disappears_NetworkAcl
=== PAUSE TestAccAWSNetworkAclRule_disappears_NetworkAcl
=== RUN   TestAccAWSNetworkAclRule_missingParam
=== PAUSE TestAccAWSNetworkAclRule_missingParam
=== RUN   TestAccAWSNetworkAclRule_ipv6
=== PAUSE TestAccAWSNetworkAclRule_ipv6
=== RUN   TestAccAWSNetworkAclRule_ipv6ICMP
=== PAUSE TestAccAWSNetworkAclRule_ipv6ICMP
=== RUN   TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate
=== PAUSE TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate
=== RUN   TestAccAWSNetworkAclRule_allProtocol
=== PAUSE TestAccAWSNetworkAclRule_allProtocol
=== RUN   TestAccAWSNetworkAclRule_tcpProtocol
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (93.48s)
=== RUN   TestAccAWSNetworkAcl_basic
=== PAUSE TestAccAWSNetworkAcl_basic
=== RUN   TestAccAWSNetworkAcl_disappears
=== PAUSE TestAccAWSNetworkAcl_disappears
=== RUN   TestAccAWSNetworkAcl_Egress_ConfigMode
=== PAUSE TestAccAWSNetworkAcl_Egress_ConfigMode
=== RUN   TestAccAWSNetworkAcl_Ingress_ConfigMode
=== PAUSE TestAccAWSNetworkAcl_Ingress_ConfigMode
=== RUN   TestAccAWSNetworkAcl_EgressAndIngressRules
=== PAUSE TestAccAWSNetworkAcl_EgressAndIngressRules
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_update
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_update
=== RUN   TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== PAUSE TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== RUN   TestAccAWSNetworkAcl_OnlyEgressRules
=== PAUSE TestAccAWSNetworkAcl_OnlyEgressRules
=== RUN   TestAccAWSNetworkAcl_SubnetChange
=== PAUSE TestAccAWSNetworkAcl_SubnetChange
=== RUN   TestAccAWSNetworkAcl_Subnets
=== PAUSE TestAccAWSNetworkAcl_Subnets
=== RUN   TestAccAWSNetworkAcl_SubnetsDelete
=== PAUSE TestAccAWSNetworkAcl_SubnetsDelete
=== RUN   TestAccAWSNetworkAcl_ipv6Rules
=== PAUSE TestAccAWSNetworkAcl_ipv6Rules
=== RUN   TestAccAWSNetworkAcl_ipv6ICMPRules
=== PAUSE TestAccAWSNetworkAcl_ipv6ICMPRules
=== RUN   TestAccAWSNetworkAcl_ipv6VpcRules
=== PAUSE TestAccAWSNetworkAcl_ipv6VpcRules
=== RUN   TestAccAWSNetworkAcl_espProtocol
=== PAUSE TestAccAWSNetworkAcl_espProtocol
=== CONT  TestAccAWSNetworkAclRule_basic
=== CONT  TestAccAWSNetworkAclRule_allProtocol
=== CONT  TestAccAWSNetworkAcl_OnlyEgressRules
=== CONT  TestAccAWSNetworkAclRule_disappears
=== CONT  TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate
=== CONT  TestAccAWSNetworkAcl_espProtocol
=== CONT  TestAccAWSNetworkAcl_ipv6VpcRules
=== CONT  TestAccAWSNetworkAcl_ipv6ICMPRules
=== CONT  TestAccAWSNetworkAcl_ipv6Rules
=== CONT  TestAccAWSNetworkAcl_SubnetsDelete
=== CONT  TestAccAWSNetworkAcl_Subnets
=== CONT  TestAccAWSNetworkAcl_SubnetChange
=== CONT  TestAccAWSNetworkAclRule_ipv6ICMP
=== CONT  TestAccAWSNetworkAclRule_ipv6
=== CONT  TestAccAWSNetworkAclRule_missingParam
=== CONT  TestAccAWSNetworkAclRule_disappears_NetworkAcl
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_update
=== CONT  TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== CONT  TestAccAWSNetworkAcl_Ingress_ConfigMode
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_basic
--- PASS: TestAccAWSNetworkAclRule_missingParam (36.11s)
=== CONT  TestAccAWSNetworkAcl_EgressAndIngressRules
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (51.38s)
=== CONT  TestAccAWSNetworkAcl_disappears
--- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (52.52s)
=== CONT  TestAccAWSNetworkAcl_Egress_ConfigMode
--- PASS: TestAccAWSNetworkAcl_espProtocol (54.71s)
=== CONT  TestAccAWSNetworkAcl_basic
--- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (55.65s)
--- PASS: TestAccAWSNetworkAclRule_ipv6 (55.92s)
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (55.99s)
--- PASS: TestAccAWSNetworkAclRule_basic (58.10s)
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (58.11s)
--- PASS: TestAccAWSNetworkAclRule_disappears (58.44s)
--- PASS: TestAccAWSNetworkAcl_ipv6Rules (67.19s)
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (68.47s)
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (69.27s)
--- PASS: TestAccAWSNetworkAcl_SubnetChange (107.33s)
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (117.61s)
--- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (56.33s)
--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (97.96s)
--- PASS: TestAccAWSNetworkAclRule_allProtocol (98.05s)
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (101.69s)
--- PASS: TestAccAWSNetworkAcl_disappears (53.03s)
--- PASS: TestAccAWSNetworkAcl_basic (55.29s)
--- PASS: TestAccAWSNetworkAcl_Subnets (116.01s)
--- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (125.71s)
--- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (126.36s)

[bflad]

LGTM 🚀

--- PASS: TestAccAWSNetworkAclRule_missingParam (21.44s)
--- PASS: TestAccAWSNetworkAclRule_disappears (27.65s)
--- PASS: TestAccAWSNetworkAcl_basic (29.21s)
--- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (31.83s)
--- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (36.96s)
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (39.53s)
--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (44.71s)
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (45.65s)
--- PASS: TestAccAWSNetworkAclRule_basic (50.72s)
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (54.40s)
--- PASS: TestAccAWSNetworkAcl_espProtocol (22.43s)
--- PASS: TestAccAWSNetworkAcl_ipv6Rules (38.00s)
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (34.70s)
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (38.82s)
--- PASS: TestAccAWSNetworkAclRule_ipv6 (68.70s)
--- PASS: TestAccAWSNetworkAcl_Subnets (69.26s)
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (69.81s)
--- PASS: TestAccAWSNetworkAcl_disappears (72.67s)
--- PASS: TestAccAWSNetworkAclRule_allProtocol (72.97s)
--- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (73.74s)
--- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (73.96s)
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (56.18s)
--- PASS: TestAccAWSNetworkAcl_SubnetChange (79.69s)
--- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (93.27s)
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (131.51s)

[ghost]

This has been released in version 2.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!