Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scheduling_strategy on aws_ecs_service #4820

Closed
mwarkentin opened this issue Jun 13, 2018 · 6 comments · Fixed by #4825
Closed

Add support for scheduling_strategy on aws_ecs_service #4820

mwarkentin opened this issue Jun 13, 2018 · 6 comments · Fixed by #4825
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Milestone

Comments

@mwarkentin
Copy link
Contributor

mwarkentin commented Jun 13, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support for daemon services (1 task per ECS instance) was just added to ECS as a schedulingStrategy attribute when creating a service (api docs). Valid values are:

  • REPLICA: this is the strategy that all ECS tasks used to be
  • DAEMON: one task per ECS instance

It would be great to be able to create services of this type with terraform.

New or Affected Resource(s)

  • aws_ecs_service

Potential Terraform Configuration

Note: I'm not sure if the scheduling_strategy values should be lowercase like most terraform configs or UPPERCASE to match the AWS API values.

resource "aws_ecs_service" "datadog" {
  name                = "datadog"
  cluster             = "${aws_ecs_cluster.foo.id}"
  task_definition     = "${aws_ecs_task_definition.datadog.arn}"
  iam_role            = "${aws_iam_role.foo.arn}"
  scheduling_strategy = "daemon"
}

References

@radeksimko radeksimko added enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. labels Jun 13, 2018
erks pushed a commit to erks/terraform-provider-aws that referenced this issue Jun 21, 2018
@SaikiranDaripelli
Copy link

Any update on when this will be merged?

@bflad bflad added this to the v1.25.0 milestone Jun 26, 2018
@bflad
Copy link
Contributor

bflad commented Jun 26, 2018

We should be able to get this released tomorrow, more shortly.

@bflad
Copy link
Contributor

bflad commented Jun 26, 2018

Support for the new scheduling_strategy argument and DAEMON ECS services has been merged in and will release with version 1.25.0 of the AWS provider tomorrow.

@bflad
Copy link
Contributor

bflad commented Jun 27, 2018

This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@billcrook
Copy link

Thanks for this! Already using it in prod.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants