service/networkmanager: Defects in attachment resources

[gdavison]

Terraform Core Version

N/A

AWS Provider Version

5.26.0

Affected Resource(s)

• aws_networkmanager_attachment_accepter
• aws_networkmanager_connect_attachment
• aws_networkmanager_site_to_site_vpn_attachment
• aws_networkmanager_transit_gateway_route_table_attachment
• aws_networkmanager_vpc_attachment

Expected Behavior

N/A

Actual Behavior

While investigating #34501, I discovered the following issues:

1. aws_networkmanager_attachment_accepter:

   • deleting aws_networkmanager_attachment_accepter does not revoke the attachment
     • addressed for VPC attachment in resource/aws_networkmanager_vpc_attachment: Allow deleting when not attached #34547

2. aws_networkmanager_vpc_attachment:

   • acceptance tests do not associate VPC attachment with a network segment, which is required for correct configuration resource/aws_networkmanager_vpc_attachment: Allow deleting when not attached #34547
   • acceptance tests do not test behaviour when acceptance is required resource/aws_networkmanager_vpc_attachment: Allow deleting when not attached #34547

3. aws_networkmanager_connect_attachment:

   • incorrectly returns error stating that non-accepted attachments cannot be deleted
   • acceptance tests do not test behaviour when acceptance is required

4. aws_networkmanager_site_to_site_vpn_attachment:

   • incorrectly returns error stating that non-accepted attachments cannot be deleted
   • acceptance tests do not test behaviour when acceptance is required

5. aws_networkmanager_transit_gateway_route_table_attachment:

   • acceptance tests do not associate VPC attachment with a network segment, which is required for correct configuration
   • acceptance tests do not test behaviour when acceptance is required

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

N/A

Steps to Reproduce

N/A

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.