Add configurable timeouts to aws_sfn_state_machine

[dylanlan]

Description

Add configurable timeouts for create, update, and delete to the aws_sfn_state_machine resource

Relations

Closes #27673.
Closes #29206.

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccSFNStateMachine_' PKG=sfn ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3  -run=TestAccSFNStateMachine_ -timeout 180m
=== RUN   TestAccSFNStateMachine_createUpdate
=== PAUSE TestAccSFNStateMachine_createUpdate
=== RUN   TestAccSFNStateMachine_expressUpdate
=== PAUSE TestAccSFNStateMachine_expressUpdate
=== RUN   TestAccSFNStateMachine_standardUpdate
=== PAUSE TestAccSFNStateMachine_standardUpdate
=== RUN   TestAccSFNStateMachine_nameGenerated
=== PAUSE TestAccSFNStateMachine_nameGenerated
=== RUN   TestAccSFNStateMachine_namePrefix
=== PAUSE TestAccSFNStateMachine_namePrefix
=== RUN   TestAccSFNStateMachine_tags
=== PAUSE TestAccSFNStateMachine_tags
=== RUN   TestAccSFNStateMachine_tracing
=== PAUSE TestAccSFNStateMachine_tracing
=== RUN   TestAccSFNStateMachine_disappears
=== PAUSE TestAccSFNStateMachine_disappears
=== RUN   TestAccSFNStateMachine_expressLogging
=== PAUSE TestAccSFNStateMachine_expressLogging
=== CONT  TestAccSFNStateMachine_createUpdate
=== CONT  TestAccSFNStateMachine_tags
=== CONT  TestAccSFNStateMachine_nameGenerated
=== CONT  TestAccSFNStateMachine_standardUpdate
--- PASS: TestAccSFNStateMachine_createUpdate (152.44s)
=== CONT  TestAccSFNStateMachine_expressUpdate
--- PASS: TestAccSFNStateMachine_tags (202.20s)
--- PASS: TestAccSFNStateMachine_standardUpdate (126.66s)
=== CONT  TestAccSFNStateMachine_disappears
--- PASS: TestAccSFNStateMachine_nameGenerated (328.99s)
=== CONT  TestAccSFNStateMachine_expressLogging
--- PASS: TestAccSFNStateMachine_disappears (167.72s)
=== CONT  TestAccSFNStateMachine_namePrefix
--- PASS: TestAccSFNStateMachine_expressUpdate (297.72s)
=== CONT  TestAccSFNStateMachine_tracing
--- PASS: TestAccSFNStateMachine_expressLogging (171.26s)
--- PASS: TestAccSFNStateMachine_namePrefix (241.96s)
--- PASS: TestAccSFNStateMachine_tracing (240.25s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sfn        740.339s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[dylanlan]

Please let me know if I need to add a test for these changes - it didn't seem like custom timeout blocks are often tested

[github-actions]

Welcome @dylanlan 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSFNStateMachine_createUpdate$$' PKG=sfn ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 2  -run=TestAccSFNStateMachine_createUpdate$ -timeout 180m
=== RUN   TestAccSFNStateMachine_createUpdate
=== PAUSE TestAccSFNStateMachine_createUpdate
=== CONT  TestAccSFNStateMachine_createUpdate
--- PASS: TestAccSFNStateMachine_createUpdate (249.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	254.614s

[ewbankkit]

@dylanlan Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.