Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add resource timeouts for aws_sfn_state_machine #27673

Closed
sairamkotapati-github opened this issue Nov 7, 2022 · 3 comments · Fixed by #31097
Closed

[Enhancement]: Add resource timeouts for aws_sfn_state_machine #27673

sairamkotapati-github opened this issue Nov 7, 2022 · 3 comments · Fixed by #31097
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service. timeouts Pertains to timeout increases.

Comments

@sairamkotapati-github
Copy link

sairamkotapati-github commented Nov 7, 2022

Description

Currently aws_sfn_state_machine does not provide access to timeouts block and defaults to 5 minutes. But in some cases deleting a state machine can take more than 5 minutes. This feature would add customizable timers for create/update/delete to service/sfn similar to this: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#timeouts

Affected Resource(s) and/or Data Source(s)

aws_sfn_state_machine

Potential Terraform Configuration

resource "aws_sfn_state_machine" "example" {
  # ...

  timeouts {
    create = "20m"
    delete = "20m"
  }
}

References

No response

Would you like to implement a fix?

No

@sairamkotapati-github sairamkotapati-github added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/sfn Issues and PRs that pertain to the sfn service. label Nov 7, 2022
@justinretzolk justinretzolk added timeouts Pertains to timeout increases. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 7, 2022
@jasonarewhy
Copy link

It would also be nice if this acted more like the API for delete and performed the operation async, rather than waiting for the delete to finish. Even without running executions, the state machine resource can take several minutes to disappear, and this adds a lot of unnecessary time to an apply.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sfn Issues and PRs that pertain to the sfn service. timeouts Pertains to timeout increases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants