Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tags for aws_db_instance data source #2988

Closed
joshma opened this issue Jan 14, 2018 · 6 comments · Fixed by #10550 or #32740
Closed

Support tags for aws_db_instance data source #2988

joshma opened this issue Jan 14, 2018 · 6 comments · Fixed by #10550 or #32740
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@joshma
Copy link

joshma commented Jan 14, 2018

Terraform Version

0.11.2.

Affected Resource(s)

Please list the resources as a list, for example:

  • aws_db_instance (data source)

Expected Behavior

When using an aws_db_instance data source, I'd like to filter by tags to find the instance.

Actual Behavior

Only db_instance_identifier is currently supported.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service. labels Jan 16, 2018
@atamgp
Copy link

atamgp commented Oct 11, 2018

yes pls add this

@sean-zou
Copy link
Contributor

I'm surprised that it is still not supported. Please add this.

@bflad
Copy link
Contributor

bflad commented Nov 2, 2019

Ah looking at the original issue here, it appears the ask is for tags as an argument (to filter results), not just returning the tags associated with a database instance. The latter will be supported in version 2.35.0 of the Terraform AWS Provider releasing next Thursday, but reopening for the original ask.

@bflad bflad reopened this Nov 2, 2019
@hemzet
Copy link

hemzet commented Aug 18, 2021

Especially when hex values are automatically added to db snapshot identifiers, as done in the TF RDS modules, the actual name of a snapshot is unknown so any data resource request fails. The tag filter extension is highly needed.

jeremychauvet added a commit to jeremychauvet/terraform-provider-aws that referenced this issue Jul 28, 2023
jeremychauvet added a commit to jeremychauvet/terraform-provider-aws that referenced this issue Jul 28, 2023
jeremychauvet added a commit to jeremychauvet/terraform-provider-aws that referenced this issue Jul 28, 2023
ewbankkit added a commit that referenced this issue Aug 3, 2023
…ces-by-tags

enhancement: add support of tags to filter RDS instances (#2988)
@github-actions github-actions bot added this to the v5.11.0 milestone Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
5 participants