Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Enhancement]: appmesh_route needs support for port matching #27698

Closed
nwsparks opened this issue Nov 8, 2022 · 4 comments · Fixed by #27799
Closed

[Bug/Enhancement]: appmesh_route needs support for port matching #27698

nwsparks opened this issue Nov 8, 2022 · 4 comments · Fixed by #27799
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/appmesh Issues and PRs that pertain to the appmesh service.
Milestone

Comments

@nwsparks
Copy link
Contributor

nwsparks commented Nov 8, 2022

Description

app mesh routes seem to require setting port matching on the route. I actually can't get it to work at all without doing this, which means that this resource is currently useless?

Affected Resource(s) and/or Data Source(s)

appmesh_route

Potential Terraform Configuration

resource "aws_appmesh_route" "routes" {
  name                = var.service_name
  mesh_name           = var.mesh_name
  virtual_router_name = var.mesh_virtual_router_name

  spec {
    http_route {
      match {
        prefix = "/"
        router_port = 8080 # new addition
      }

      action {
        weighted_target {
          virtual_node = aws_appmesh_virtual_node.node[0].name
          weight       = 100
          target_port  = 80 # new addition
        }
      }
    }
  }
}

References

error when adding router listeners:

image

port config from gui:
image

Would you like to implement a fix?

No response

@nwsparks nwsparks added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Nov 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/appmesh Issues and PRs that pertain to the appmesh service. label Nov 8, 2022
@justinretzolk justinretzolk added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 8, 2022
@dgr237
Copy link
Contributor

dgr237 commented Nov 12, 2022

In addition aws_appmesh_virtual_gateway only supports a single listener (even though #14169 states this has been implemented). Also aws_appmesh_gateway_route would also need to support the matching on port and the target port setting).

@github-actions
Copy link

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants