aws_datasync_agent with activation_key is not idempotent

[limitusus]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.14.11

• provider registry.terraform.io/hashicorp/aws v3.46.0

Affected Resource(s)

• aws_datasync_agent

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

resource "aws_datasync_agent" "nfs" {
  name = "nfs"

  activation_key        = "AAAAA-BBBBB-CCCCC-DDDDD-EEEEE"
  security_group_arns   = [data.aws_security_group.default.arn]
  subnet_arns           = [data.aws_subnet.datasync_nfs.arn]
  vpc_endpoint_id       = aws_vpc_endpoint.datasync.id
}

Debug Output

Panic Output

N/A

Expected Behavior

After terraform apply, and then terraform plan, no diff should appear.

Actual Behavior

terraform apply itself succeeds, however a drift with replacement is detected as follows:

  # aws_datasync_agent.nfs must be replaced
-/+ resource "aws_datasync_agent" "nfs" {
      ~ arn                   = "arn:aws:datasync:ap-northeast-1:123456789012:agent/agent-01234567890123456" -> (known after apply)
      ~ id                    = "arn:aws:datasync:ap-northeast-1:123456789012:agent/agent-01234567890123456" -> (known after apply)
      + ip_address            = (known after apply)
        name                  = "nfs"
      - private_link_endpoint = "10.0.4.125" -> null # forces replacement
        # (5 unchanged attributes hidden)
    }

Steps to Reproduce

1. Put aws_datasync_agent with activation_key, not ip_address
2. terraform apply
3. terraform plan

Important Factoids

References

• resource/aws_datasync_agent: Add support for VPC Endpoints #16207

btw resource name in https://github.com/hashicorp/terraform-provider-aws/pull/16207/files#diff-f934b36f3fe5b685db4381f7c9f77e790e65db91e86e7c8423cab27d050eb831 should be fixed from aws_datasync_option to aws_datasync_agent

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.