r/sns_topic - add firehose args #19528

DrFaust92 · 2021-05-26T06:41:37Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19491

Output from acceptance testing:

$ make testacc TESTARGS='-run=estAccAWSSNSTopic_'
--- PASS: TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError (27.21s)
--- PASS: TestAccAWSSNSTopic_disappears (79.28s)
--- PASS: TestAccAWSSNSTopic_NamePrefix_FIFOTopic (91.97s)
--- PASS: TestAccAWSSNSTopic_Name (95.23s)
--- PASS: TestAccAWSSNSTopic_Name_Generated_FIFOTopic (100.60s)
--- PASS: TestAccAWSSNSTopic_basic (101.00s)
--- PASS: TestAccAWSSNSTopic_policy (101.56s)
--- PASS: TestAccAWSSNSTopic_Name_FIFOTopic (101.80s)
--- PASS: TestAccAWSSNSTopic_NamePrefix (102.29s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (102.33s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (107.71s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (119.73s)
--- PASS: TestAccAWSSNSTopic_encryption (135.00s)
--- PASS: TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication (139.15s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (163.18s)
--- PASS: TestAccAWSSNSTopic_tags (173.28s)

ewbankkit

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopic_'                                
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopic_ -timeout 180m
=== RUN   TestAccAWSSNSTopic_basic
=== PAUSE TestAccAWSSNSTopic_basic
=== RUN   TestAccAWSSNSTopic_Name
=== PAUSE TestAccAWSSNSTopic_Name
=== RUN   TestAccAWSSNSTopic_NamePrefix
=== PAUSE TestAccAWSSNSTopic_NamePrefix
=== RUN   TestAccAWSSNSTopic_policy
=== PAUSE TestAccAWSSNSTopic_policy
=== RUN   TestAccAWSSNSTopic_withIAMRole
=== PAUSE TestAccAWSSNSTopic_withIAMRole
=== RUN   TestAccAWSSNSTopic_withFakeIAMRole
=== PAUSE TestAccAWSSNSTopic_withFakeIAMRole
=== RUN   TestAccAWSSNSTopic_withDeliveryPolicy
=== PAUSE TestAccAWSSNSTopic_withDeliveryPolicy
=== RUN   TestAccAWSSNSTopic_deliveryStatus
=== PAUSE TestAccAWSSNSTopic_deliveryStatus
=== RUN   TestAccAWSSNSTopic_Name_Generated_FIFOTopic
=== PAUSE TestAccAWSSNSTopic_Name_Generated_FIFOTopic
=== RUN   TestAccAWSSNSTopic_Name_FIFOTopic
=== PAUSE TestAccAWSSNSTopic_Name_FIFOTopic
=== RUN   TestAccAWSSNSTopic_NamePrefix_FIFOTopic
=== PAUSE TestAccAWSSNSTopic_NamePrefix_FIFOTopic
=== RUN   TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication
=== PAUSE TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication
=== RUN   TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError
=== PAUSE TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError
=== RUN   TestAccAWSSNSTopic_encryption
=== PAUSE TestAccAWSSNSTopic_encryption
=== RUN   TestAccAWSSNSTopic_tags
=== PAUSE TestAccAWSSNSTopic_tags
=== RUN   TestAccAWSSNSTopic_disappears
=== PAUSE TestAccAWSSNSTopic_disappears
=== CONT  TestAccAWSSNSTopic_basic
=== CONT  TestAccAWSSNSTopic_Name_FIFOTopic
=== CONT  TestAccAWSSNSTopic_withFakeIAMRole
=== CONT  TestAccAWSSNSTopic_disappears
=== CONT  TestAccAWSSNSTopic_tags
=== CONT  TestAccAWSSNSTopic_encryption
=== CONT  TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError
=== CONT  TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication
=== CONT  TestAccAWSSNSTopic_NamePrefix_FIFOTopic
=== CONT  TestAccAWSSNSTopic_policy
=== CONT  TestAccAWSSNSTopic_withIAMRole
=== CONT  TestAccAWSSNSTopic_Name_Generated_FIFOTopic
=== CONT  TestAccAWSSNSTopic_Name
=== CONT  TestAccAWSSNSTopic_deliveryStatus
=== CONT  TestAccAWSSNSTopic_withDeliveryPolicy
=== CONT  TestAccAWSSNSTopic_NamePrefix
--- PASS: TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError (6.11s)
--- PASS: TestAccAWSSNSTopic_disappears (18.21s)
--- PASS: TestAccAWSSNSTopic_basic (22.01s)
--- PASS: TestAccAWSSNSTopic_Name_Generated_FIFOTopic (23.66s)
--- PASS: TestAccAWSSNSTopic_Name_FIFOTopic (25.54s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (25.61s)
--- PASS: TestAccAWSSNSTopic_Name (25.76s)
--- PASS: TestAccAWSSNSTopic_NamePrefix_FIFOTopic (25.81s)
--- PASS: TestAccAWSSNSTopic_NamePrefix (25.89s)
--- PASS: TestAccAWSSNSTopic_policy (26.04s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (32.65s)
--- PASS: TestAccAWSSNSTopic_encryption (38.04s)
--- PASS: TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication (38.22s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (38.56s)
--- PASS: TestAccAWSSNSTopic_tags (47.57s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (131.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	134.253s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopic_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopic_ -timeout 180m
=== RUN   TestAccAWSSNSTopic_basic
=== PAUSE TestAccAWSSNSTopic_basic
=== RUN   TestAccAWSSNSTopic_Name
=== PAUSE TestAccAWSSNSTopic_Name
=== RUN   TestAccAWSSNSTopic_NamePrefix
=== PAUSE TestAccAWSSNSTopic_NamePrefix
=== RUN   TestAccAWSSNSTopic_policy
=== PAUSE TestAccAWSSNSTopic_policy
=== RUN   TestAccAWSSNSTopic_withIAMRole
=== PAUSE TestAccAWSSNSTopic_withIAMRole
=== RUN   TestAccAWSSNSTopic_withFakeIAMRole
=== PAUSE TestAccAWSSNSTopic_withFakeIAMRole
=== RUN   TestAccAWSSNSTopic_withDeliveryPolicy
=== PAUSE TestAccAWSSNSTopic_withDeliveryPolicy
=== RUN   TestAccAWSSNSTopic_deliveryStatus
=== PAUSE TestAccAWSSNSTopic_deliveryStatus
=== RUN   TestAccAWSSNSTopic_Name_Generated_FIFOTopic
=== PAUSE TestAccAWSSNSTopic_Name_Generated_FIFOTopic
=== RUN   TestAccAWSSNSTopic_Name_FIFOTopic
=== PAUSE TestAccAWSSNSTopic_Name_FIFOTopic
=== RUN   TestAccAWSSNSTopic_NamePrefix_FIFOTopic
=== PAUSE TestAccAWSSNSTopic_NamePrefix_FIFOTopic
=== RUN   TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication
=== PAUSE TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication
=== RUN   TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError
=== PAUSE TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError
=== RUN   TestAccAWSSNSTopic_encryption
=== PAUSE TestAccAWSSNSTopic_encryption
=== RUN   TestAccAWSSNSTopic_tags
=== PAUSE TestAccAWSSNSTopic_tags
=== RUN   TestAccAWSSNSTopic_disappears
=== PAUSE TestAccAWSSNSTopic_disappears
=== CONT  TestAccAWSSNSTopic_basic
=== CONT  TestAccAWSSNSTopic_Name_FIFOTopic
=== CONT  TestAccAWSSNSTopic_encryption
=== CONT  TestAccAWSSNSTopic_policy
=== CONT  TestAccAWSSNSTopic_Name
=== CONT  TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication
=== CONT  TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError
=== CONT  TestAccAWSSNSTopic_deliveryStatus
=== CONT  TestAccAWSSNSTopic_withFakeIAMRole
=== CONT  TestAccAWSSNSTopic_withDeliveryPolicy
=== CONT  TestAccAWSSNSTopic_NamePrefix_FIFOTopic
=== CONT  TestAccAWSSNSTopic_tags
=== CONT  TestAccAWSSNSTopic_Name_Generated_FIFOTopic
=== CONT  TestAccAWSSNSTopic_withIAMRole
=== CONT  TestAccAWSSNSTopic_disappears
=== CONT  TestAccAWSSNSTopic_NamePrefix
--- PASS: TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError (8.34s)
=== CONT  TestAccAWSSNSTopic_NamePrefix_FIFOTopic
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/05/26 09:28:10 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating SNS Topic (tf-acc-test-prefix-20210526132813653100000009.fifo): InvalidParameter: Invalid parameter: Attributes Reason: Unknown attribute FifoTopic
        	status code: 400, request id: 83357b6a-1268-5964-a463-22425d457869
        
          on terraform_plugin_test.tf line 2, in resource "aws_sns_topic" "test":
           2: resource "aws_sns_topic" "test" {
        
        
=== CONT  TestAccAWSSNSTopic_Name_Generated_FIFOTopic
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/05/26 09:28:10 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating SNS Topic (terraform-20210526132813641500000007.fifo): InvalidParameter: Invalid parameter: Attributes Reason: Unknown attribute FifoTopic
        	status code: 400, request id: 3ffa16f8-366e-5a83-a5b1-4fd07943398f
        
          on terraform_plugin_test.tf line 2, in resource "aws_sns_topic" "test":
           2: resource "aws_sns_topic" "test" {
        
        
=== CONT  TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/05/26 09:28:10 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating SNS Topic (terraform-test-topic-gjeffba2xv.fifo): InvalidParameter: Invalid parameter: Attributes Reason: Unknown attribute FifoTopic
        	status code: 400, request id: 8bfe25fc-99ff-5ce1-a8fd-7cd4d6d21dcc
        
          on terraform_plugin_test.tf line 2, in resource "aws_sns_topic" "test":
           2: resource "aws_sns_topic" "test" {
        
        
=== CONT  TestAccAWSSNSTopic_Name_FIFOTopic
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/05/26 09:28:11 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating SNS Topic (tf-acc-test-8095600753192609537.fifo): InvalidParameter: Invalid parameter: Attributes Reason: Unknown attribute FifoTopic
        	status code: 400, request id: faca1dff-728e-5cc7-8c96-44d73da001e0
        
          on terraform_plugin_test.tf line 2, in resource "aws_sns_topic" "test":
           2: resource "aws_sns_topic" "test" {
        
        
--- SKIP: TestAccAWSSNSTopic_NamePrefix_FIFOTopic (11.70s)
--- SKIP: TestAccAWSSNSTopic_Name_Generated_FIFOTopic (11.72s)
--- SKIP: TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication (11.73s)
--- SKIP: TestAccAWSSNSTopic_Name_FIFOTopic (11.78s)
--- PASS: TestAccAWSSNSTopic_disappears (20.16s)
--- PASS: TestAccAWSSNSTopic_NamePrefix (25.69s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (27.08s)
--- PASS: TestAccAWSSNSTopic_basic (27.21s)
--- PASS: TestAccAWSSNSTopic_Name (27.41s)
--- PASS: TestAccAWSSNSTopic_policy (27.45s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (35.06s)
--- PASS: TestAccAWSSNSTopic_encryption (40.61s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (42.39s)
--- PASS: TestAccAWSSNSTopic_tags (60.14s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (134.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	137.590s

ghost · 2021-06-01T17:38:54Z

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

github-actions · 2021-07-03T02:03:30Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

DrFaust92 added 2 commits May 26, 2021 09:38

add firehose args

6d3b8c9

docs

0991527

ghost added size/L Managed by automation to categorize the size of a PR. labels May 26, 2021

github-actions bot added documentation Introduces or discusses updates to documentation. service/sns Issues and PRs that pertain to the sns service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 26, 2021

changelog

ae720e5

DrFaust92 changed the title ~~rd/sns_topic - add firehose args~~ r/sns_topic - add firehose args May 26, 2021

DrFaust92 marked this pull request as ready for review May 26, 2021 06:45

DrFaust92 requested a review from a team as a code owner May 26, 2021 06:45

ewbankkit approved these changes May 26, 2021

View reviewed changes

ewbankkit merged commit a774dfa into hashicorp:main May 26, 2021

github-actions bot added this to the v3.43.0 milestone May 26, 2021

DrFaust92 deleted the r/sns_topic_firehose branch May 26, 2021 13:39

github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/sns_topic - add firehose args #19528

r/sns_topic - add firehose args #19528

DrFaust92 commented May 26, 2021 •

edited

Loading

ewbankkit left a comment

ghost commented Jun 1, 2021

github-actions bot commented Jul 3, 2021

r/sns_topic - add firehose args #19528

r/sns_topic - add firehose args #19528

Conversation

DrFaust92 commented May 26, 2021 • edited Loading

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ghost commented Jun 1, 2021

github-actions bot commented Jul 3, 2021

DrFaust92 commented May 26, 2021 •

edited

Loading