Support FirehoseSuccessFeedbackRoleArn in SNS topics

[drmaciej]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As per https://docs.aws.amazon.com/sns/latest/dg/sns-topic-attributes.html, Delivery Status Logging supports HTTP, Amazon Kinesis Data Firehose, AWS Lambda, Platform application endpoint & Amazon Simple Queue Service. The provider, right now, does not support Firehose.

New or Affected Resource(s)

• aws_sns_topic
• aws_sns_topic

Potential Terraform Configuration

resource "aws_sns_topic" "topic" {
  name = var.topic_name

  firehose_failure_feedback_role_arn            = var.feedback_role_arn
  firehose_success_feedback_role_arn            = var.feedback_role_arn
  firehose_success_feedback_sample_rate         = 0
}

References

• #0000

[ghost]

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.