Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_elasticsearch_domain_saml_options: New resource #19497

Merged
merged 6 commits into from
Jun 22, 2021

Conversation

philof
Copy link
Contributor

@philof philof commented May 24, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #16259
Relates #16424

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticSearchDomainSAMLOptions*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticSearchDomainSAMLOptions* -timeout 180m
=== RUN   TestAccAWSElasticSearchDomainSAMLOptions_basic
=== PAUSE TestAccAWSElasticSearchDomainSAMLOptions_basic
=== RUN   TestAccAWSElasticSearchDomainSAMLOptions_disappears
=== PAUSE TestAccAWSElasticSearchDomainSAMLOptions_disappears
=== RUN   TestAccAWSElasticSearchDomainSAMLOptions_disappears_Domain
=== PAUSE TestAccAWSElasticSearchDomainSAMLOptions_disappears_Domain
=== RUN   TestAccAWSElasticSearchDomainSAMLOptions_Update
=== PAUSE TestAccAWSElasticSearchDomainSAMLOptions_Update
=== CONT  TestAccAWSElasticSearchDomainSAMLOptions_basic
=== CONT  TestAccAWSElasticSearchDomainSAMLOptions_Update
=== CONT  TestAccAWSElasticSearchDomainSAMLOptions_disappears
=== CONT  TestAccAWSElasticSearchDomainSAMLOptions_disappears_Domain
--- PASS: TestAccAWSElasticSearchDomainSAMLOptions_disappears (1050.52s)
--- PASS: TestAccAWSElasticSearchDomainSAMLOptions_Update (1237.55s)
--- PASS: TestAccAWSElasticSearchDomainSAMLOptions_basic (1310.63s)
--- PASS: TestAccAWSElasticSearchDomainSAMLOptions_disappears_Domain (1453.73s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1453.830s

@philof philof requested a review from a team as a code owner May 24, 2021 15:27
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. labels May 24, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 24, 2021
@JeffAshton
Copy link
Contributor

Looks like the linter has some minor indentation issues.

@bill-rich bill-rich self-requested a review June 17, 2021 15:48
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 22, 2021
@bill-rich bill-rich force-pushed the r/elasticsearch_domain_saml_options branch 4 times, most recently from a1ef274 to e853695 Compare June 22, 2021 17:51
@bill-rich bill-rich force-pushed the r/elasticsearch_domain_saml_options branch from e853695 to 1894ccf Compare June 22, 2021 17:55
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needed a few small changes and docs added. LGTM

@bill-rich bill-rich merged commit 694895f into hashicorp:main Jun 22, 2021
@github-actions github-actions bot added this to the v3.47.0 milestone Jun 22, 2021
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: ElasticSearch - native SAML Authentication for Kibana
4 participants