r/aws_globalaccelerator_accelerator: Correct name validation length

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17978.
Relates: #14601.

Output from acceptance testing:

$ ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorListener_\|TestAccAwsGlobalAcceleratorAccelerator_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAwsGlobalAcceleratorListener_\|TestAccAwsGlobalAcceleratorAccelerator_ -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_basic
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_basic
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_disappears
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_disappears
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_update
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_update
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_attributes
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_attributes
=== RUN   TestAccAwsGlobalAcceleratorAccelerator_tags
=== PAUSE TestAccAwsGlobalAcceleratorAccelerator_tags
=== RUN   TestAccAwsGlobalAcceleratorListener_basic
=== PAUSE TestAccAwsGlobalAcceleratorListener_basic
=== RUN   TestAccAwsGlobalAcceleratorListener_disappears
=== PAUSE TestAccAwsGlobalAcceleratorListener_disappears
=== RUN   TestAccAwsGlobalAcceleratorListener_update
=== PAUSE TestAccAwsGlobalAcceleratorListener_update
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_basic
=== CONT  TestAccAwsGlobalAcceleratorListener_basic
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (70.93s)
=== CONT  TestAccAwsGlobalAcceleratorListener_update
--- PASS: TestAccAwsGlobalAcceleratorListener_basic (113.72s)
=== CONT  TestAccAwsGlobalAcceleratorListener_disappears
--- PASS: TestAccAwsGlobalAcceleratorListener_update (180.45s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_attributes
--- PASS: TestAccAwsGlobalAcceleratorListener_disappears (151.63s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_tags
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (98.71s)
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_update
=== CONT  TestAccAwsGlobalAcceleratorAccelerator_disappears
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (144.97s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_attributes (280.63s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_disappears (64.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	573.286s

[DrFaust92]

LGTM

--- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (106.25s)--- PASS: TestAccAwsGlobalAcceleratorListener_basic (147.17s)
--- PASS: TestAccAwsGlobalAcceleratorListener_disappears (126.04s)
--- PASS: TestAccAwsGlobalAcceleratorListener_update (228.36s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (198.08s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (193.01s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_disappears (79.98s)

there was also one unrelated error:

Error: error deleting S3 Bucket (tf-acc-test-8066618524275417147): BucketNotEmpty: The bucket you tried to delete is not empty
	status code: 409
        
--- FAIL: TestAccAwsGlobalAcceleratorAccelerator_attributes (519.52s)

[ewbankkit]

I'll investigate that error...

It looks valid - there could be some flow logs written into the test bucket during the acceptance test.
Opened #18121.

[bflad]

Following the API documentation (longer of 255 and 64) is safer for now. If the actual limit is 64 and the API model is updated to reflect that, we can always lower it again. 👍 Looks good to me. 🚀

Output from acceptance testing in AWS Commercial:

--- FAIL: TestAccAwsGlobalAcceleratorAccelerator_attributes (361.78s) # https://github.com/hashicorp/terraform-provider-aws/issues/18121
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_basic (78.46s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_disappears (73.64s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_tags (107.66s)
--- PASS: TestAccAwsGlobalAcceleratorAccelerator_update (166.17s)

--- PASS: TestAccAwsGlobalAcceleratorListener_basic (136.40s)
--- PASS: TestAccAwsGlobalAcceleratorListener_disappears (134.18s)
--- PASS: TestAccAwsGlobalAcceleratorListener_update (178.99s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAwsGlobalAcceleratorAccelerator_attributes (30.06s)
--- SKIP: TestAccAwsGlobalAcceleratorAccelerator_basic (36.40s)
--- SKIP: TestAccAwsGlobalAcceleratorAccelerator_tags (28.51s)
--- SKIP: TestAccAwsGlobalAcceleratorAccelerator_update (27.43s)
--- SKIP: TestAccAwsGlobalAcceleratorAccelerator_disappears (28.93s)

--- SKIP: TestAccAwsGlobalAcceleratorListener_basic (28.74s)
--- SKIP: TestAccAwsGlobalAcceleratorListener_disappears (31.23s)
--- SKIP: TestAccAwsGlobalAcceleratorListener_update (30.72s)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!