Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation check of Global Accelerator is different from AWS Console #17978

Closed
n-osanai opened this issue Mar 8, 2021 · 6 comments · Fixed by #17985
Closed

Validation check of Global Accelerator is different from AWS Console #17978

n-osanai opened this issue Mar 8, 2021 · 6 comments · Fixed by #17985
Assignees
Labels
bug Addresses a defect in current functionality. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service.

Comments

@n-osanai
Copy link

n-osanai commented Mar 8, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.13.5
+ provider registry.terraform.io/hashicorp/aws v3.31.0

Affected Resource(s)

  • aws_globalaccelerator_accelerator

Terraform Configuration Files

provider "aws" {
  region = "us-east-1"
}

resource "aws_globalaccelerator_accelerator" "example" {
  name = "test-accelerator-test-accelerator"
}

Debug Output

Expected Behavior

  • Terraform create the accelerator with over 32 characters name.

Actual Behavior

Error: expected length of name to be in the range (1 - 32), got test-accelerator-test-accelerator

  on main.tf line 3, in resource "aws_globalaccelerator_accelerator" "this":
   3:   name            = "test-accelerator-test-accelerator"

Steps to Reproduce

  1. only try to create global accelerator with over 32 characters name.

Important Factoids

  • AWS document says confusing sentences.
  • But I examined, It seems that It can create global accelerator with up to 64 characters.

スクリーンショット 2021-03-08 20 42 16

  • Actually, I can create 64 characters global accelerator.

スクリーンショット 2021-03-08 20 44 13

@ghost ghost added the service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. label Mar 8, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 8, 2021
@ewbankkit
Copy link
Contributor

@n-osanai Thanks for raising this issue.
The AWS API documentation is self-contradictory:

Screenshot 2021-03-08 074724

I'll correct the max. length to 255 (and double check the other attributes).

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 8, 2021
@ewbankkit ewbankkit self-assigned this Mar 8, 2021
@chkelly
Copy link

chkelly commented Mar 8, 2021

My team just ran into the 32 character limitation when attempting to import our production global accelerator instances which have a name that exceeds 32 characters.

I reached out to our AWS TAM around the contradictory nature of the docs and they have escalated to the service team to hopefully get them corrected.

Based on our testing the Max length of 255 seems to be the actual limitation that is enforced.

@ewbankkit
Copy link
Contributor

@e-moshaya
Copy link

e-moshaya commented Mar 15, 2021

We've just been hit with the same issue. The name can have a maximum of 64 characters, must contain only alphanumeric characters, periods (.), or hyphens (-), and must not begin or end with a hyphen or period. You can check the API documentation here: https://docs.aws.amazon.com/global-accelerator/latest/api/API_CreateAccelerator.html#API_CreateAccelerator_RequestSyntax

@e-moshaya
Copy link

@ewbankkit The actual max length is 64 and not 255. Please can you amend your PR?

@ghost
Copy link

ghost commented Apr 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants