Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeatureRequest: Specify kinesis stream as the source of a aws_kinesis_firehose_delivery_stream #1601

Closed
pleschev opened this issue Sep 6, 2017 · 4 comments
Closed

FeatureRequest: Specify kinesis stream as the source of a aws_kinesis_firehose_delivery_stream #1601

pleschev opened this issue Sep 6, 2017 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Milestone
v1.1.0

Comments

@pleschev
Copy link
Contributor

pleschev commented Sep 6, 2017

No description provided.

@pleschev
Copy link
Contributor Author

pleschev commented Sep 6, 2017

I'm going to have a crack at creating a pull request for this functionality

pleschev pushed a commit to pleschev/terraform-provider-aws that referenced this issue Sep 7, 2017
First attempt at resolving hashicorp#1601
4df9a47
@pleschev pleschev mentioned this issue Sep 7, 2017
Merged
@Ninir Ninir added the bug Addresses a defect in current functionality. label Sep 18, 2017
@Ninir Ninir added enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. labels Sep 27, 2017
Ninir pushed a commit that referenced this issue Oct 12, 2017
@pleschev @Ninir
Specify kinesis stream as the source of a aws_kinesis_firehose_delive…
de474a8 
…ry_stream (#1605)

* First attempt at resolving #1601

* Removing unused method

* Add acceptance test for aws_kinesis_firehose_delivery_stream using Kinesis Stream as source

* Updated "source_configuration" to be "kinesis_source_configuration"
@radeksimko radeksimko added the service/firehose Issues and PRs that pertain to the firehose service. label Jan 15, 2018
@ewbankkit
Copy link
Contributor

@bflad This issue was resolved with #1605 and can be closed.

@bflad bflad added this to the v1.1.0 milestone Aug 29, 2019
@bflad
Copy link
Contributor

bflad commented Aug 29, 2019

Indeed! This was released a very long time ago in version 1.1.0 of the Terraform AWS Provider.

@bflad bflad closed this as completed Aug 29, 2019
@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
5 participants
@bflad @radeksimko @pleschev @Ninir @ewbankkit