Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e - fsx - updated max retention days from 35 to 90 #15641

Merged
merged 2 commits into from
Oct 20, 2020
Merged

e - fsx - updated max retention days from 35 to 90 #15641

merged 2 commits into from
Oct 20, 2020

Conversation

philnichol
Copy link
Contributor

@philnichol philnichol commented Oct 14, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15636
Closes #15655

Release note for CHANGELOG:

Increased fsx_windows_file_system maximum automatic_backup_retention_days from 35 to 90.
Increased fsx_lustre_file_system maximum automatic_backup_retention_days from 35 to 90.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
$ TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays -timeout 60m
=== RUN   TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
=== PAUSE TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
=== CONT  TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
--- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (3102.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3104.356s

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays -timeout 60m
=== RUN   TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== CONT  TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
--- PASS: TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays (667.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	669.709s

As per docs the maximum retention days should indeed be 90:
https://docs.aws.amazon.com/sdk-for-go/api/service/fsx/#CreateFileSystemWindowsConfiguration

@philnichol philnichol requested a review from a team October 14, 2020 16:59
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 14, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 14, 2020
@gdavison gdavison self-assigned this Oct 15, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Oct 15, 2020
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- FAIL: TestAccAWSFsxLustreFileSystem_ExportPath (7.54s)
--- FAIL: TestAccAWSFsxLustreFileSystem_ImportPath (8.71s)
--- FAIL: TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize (8.45s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheNone (508.99s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 (509.70s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (527.18s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheRead (550.17s)
--- PASS: TestAccAWSFsxLustreFileSystem_Tags (595.30s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2 (610.21s)
--- PASS: TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime (652.78s)
--- PASS: TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime (675.67s)
--- PASS: TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays (676.26s)
--- PASS: TestAccAWSFsxLustreFileSystem_disappears (719.76s)
--- PASS: TestAccAWSFsxLustreFileSystem_KmsKeyId (1000.98s)
--- PASS: TestAccAWSFsxLustreFileSystem_autoImportPolicy (1043.18s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (1099.66s)
--- PASS: TestAccAWSFsxLustreFileSystem_SecurityGroupIds (1204.43s)
--- PASS: TestAccAWSFsxWindowsFileSystem_disappears (3036.58s)
--- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (3112.15s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3193.43s)
--- PASS: TestAccAWSFsxWindowsFileSystem_singleAz2 (3385.56s)
--- PASS: TestAccAWSFsxWindowsFileSystem_storageTypeHdd (3484.91s)
--- PASS: TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime (3058.51s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory (2975.55s)
--- PASS: TestAccAWSFsxWindowsFileSystem_multiAz (3715.92s)
--- PASS: TestAccAWSFsxWindowsFileSystem_Tags (3076.20s)
--- PASS: TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime (3171.69s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username (3835.97s)
--- PASS: TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups (4158.53s)
--- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (4147.01s)
--- PASS: TestAccAWSFsxWindowsFileSystem_KmsKeyId (4378.24s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SecurityGroupIds (4554.35s)
--- PASS: TestAccAWSFsxWindowsFileSystem_StorageCapacity (4780.45s)

Acceptance test failures are pre-existing

@gdavison gdavison added this to the v3.12.0 milestone Oct 17, 2020
@gdavison gdavison merged commit 2488455 into hashicorp:master Oct 20, 2020
gdavison added a commit that referenced this pull request Oct 20, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/fsx Issues and PRs that pertain to the fsx service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants