Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maximum retention days from 35 to 90 (in accordance to AWS) #15636

Closed
ddup1 opened this issue Oct 14, 2020 · 2 comments · Fixed by #15641
Closed

Update maximum retention days from 35 to 90 (in accordance to AWS) #15636

ddup1 opened this issue Oct 14, 2020 · 2 comments · Fixed by #15641
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Milestone

Comments

@ddup1
Copy link

ddup1 commented Oct 14, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When deploying a aws_fsx_windows_file_system with terraform we can set parameter automatic_backup_retention_days from 0 to 35. But in AWS we can now set this retention up to 90 days. Please update provider in accordance to AWS settings limit.

New or Affected Resource(s)

  • aws_fsx_windows_file_system

Potential Terraform Configuration

resource "aws_fsx_windows_file_system" "fsx" {
automatic_backup_retention_days = 90
}

References

https://docs.aws.amazon.com/fsx/latest/WindowsGuide/using-backups.html

  • #0000
@ddup1 ddup1 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 14, 2020
@ghost ghost added the service/fsx Issues and PRs that pertain to the fsx service. label Oct 14, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 14, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Oct 15, 2020
@gdavison gdavison added this to the v3.12.0 milestone Oct 17, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants