added metadata_options for aws_launch_config

[jaysiyani]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14621

Release note for CHANGELOG:

data-source/aws_launch_config: Add metadata_options attribute
resource/aws_launch_template: Add metadata_options configuration block (support IMDSv2)

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchConfiguration_metadataOptions'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfiguration_metadataOptions -timeout 120m
=== RUN   TestAccAWSLaunchConfiguration_metadataOptions
=== PAUSE TestAccAWSLaunchConfiguration_metadataOptions
=== CONT  TestAccAWSLaunchConfiguration_metadataOptions
--- PASS: TestAccAWSLaunchConfiguration_metadataOptions (14.95s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       15.007s

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccLaunchConfigurationDataSource_metadataOptions'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccLaunchConfigurationDataSource_metadataOptions -timeout 120m
=== RUN   TestAccLaunchConfigurationDataSource_metadataOptions
=== PAUSE TestAccLaunchConfigurationDataSource_metadataOptions
=== CONT  TestAccLaunchConfigurationDataSource_metadataOptions
--- PASS: TestAccLaunchConfigurationDataSource_metadataOptions (13.93s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       13.978s

...

[willfarrell]

For those using Security Hub, AWS Foundational Security Best Practices v1.0.0 EC2.8 checks for this. Would be great to have this security feature merged.

[jaysiyani]

@breathingdust Is there anything else needed in this PR for it to be merged?

[dvanteru]

@breathingdust For security compliance we have to implement this change, can this be merged sooner than later please? Thank you very much

[breathingdust]

Hi @jaysiyani thanks for the contribution for what looks like a popular enhancement! The FAQ covers how we decide what gets merged and when. We appreciate your patience while we work through our backlog!

[bflad]

Hi @jaysiyani 👋 Thank you for submitting this. Overall its looking pretty good, just needs resource documentation and a test configuration fix, then should be good to get in. Please reach out if you have any questions or do not have time to make the changes. 👍

[jaysiyani]

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchConfiguration_metadataOptions'    
==> Checking that code complies with gofmt requirements...        
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfiguration_metadataOptions -timeout 120m
=== RUN   TestAccAWSLaunchConfiguration_metadataOptions
=== PAUSE TestAccAWSLaunchConfiguration_metadataOptions
=== CONT  TestAccAWSLaunchConfiguration_metadataOptions
--- PASS: TestAccAWSLaunchConfiguration_metadataOptions (30.53s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       30.590s

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccLaunchConfigurationDataSource_metadataOptions'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccLaunchConfigurationDataSource_metadataOptions -timeout 120m
=== RUN   TestAccLaunchConfigurationDataSource_metadataOptions
=== PAUSE TestAccLaunchConfigurationDataSource_metadataOptions
=== CONT  TestAccLaunchConfigurationDataSource_metadataOptions
--- PASS: TestAccLaunchConfigurationDataSource_metadataOptions (27.39s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       27.446s

[apolegoshko]

@bflad when it's planned to be merged ? Thanks in advance

[bflad]

Looks good, thank you, @jaysiyani 🚀

Output from acceptance testing:

--- PASS: TestAccAWSLaunchConfiguration_basic (73.44s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (52.92s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (52.90s)
--- PASS: TestAccAWSLaunchConfiguration_metadataOptions (55.79s)
--- PASS: TestAccAWSLaunchConfiguration_RootBlockDevice_AmiDisappears (373.76s)
--- PASS: TestAccAWSLaunchConfiguration_RootBlockDevice_VolumeSize (76.39s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (74.31s)
--- PASS: TestAccAWSLaunchConfiguration_userData (75.41s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (55.41s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (55.17s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (60.63s)
--- PASS: TestAccAWSLaunchConfiguration_withInstanceStoreAMI (57.10s)
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (55.55s)

--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (53.40s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_ebsNoDevice (52.04s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (49.80s)
--- PASS: TestAccLaunchConfigurationDataSource_metadataOptions (54.83s)

[ghost]

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!