Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_launch_configuration add support for Instance Metadata Options #14621

Closed
jaysiyani opened this issue Aug 13, 2020 · 4 comments
Closed

aws_launch_configuration add support for Instance Metadata Options #14621

jaysiyani opened this issue Aug 13, 2020 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Milestone

Comments

@jaysiyani
Copy link
Contributor

jaysiyani commented Aug 13, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently the aws_launch_configuration resource does not support Instance Metadata Options. These options can be required when using the Instance Metadata Service Version 2, which new versions of the AWS SDK now use:

Following can be done by aws-cli

aws autoscaling create-launch-configuration \
  --launch-configuration-name my-lc-with-imdsv2 \
  --image-id ami-01e24be29428c15b2 \
  --instance-type t2.micro \
      ...    
  --metadata-options "HttpEndpoint=enabled,HttpTokens=required" 

New or Affected Resource(s)

  • aws_launch_configuration

Potential Terraform Configuration

resource "aws_launch_configuration" "foo" {
  name = "foo"
  metadata_options {
    http_endpoint               = "enabled"
    http_put_response_hop_limit = 2
    http_tokens                 = "required"
  }
}

References

@jaysiyani jaysiyani added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 13, 2020
@ghost ghost added the service/autoscaling Issues and PRs that pertain to the autoscaling service. label Aug 13, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 13, 2020
@jaysiyani
Copy link
Contributor Author

jaysiyani commented Aug 13, 2020

PR #14637
Any help / tips / advice highly appreciated.

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Dec 15, 2020
@bflad bflad added this to the v3.22.0 milestone Dec 15, 2020
@bflad
Copy link
Contributor

bflad commented Dec 15, 2020

Support for this functionality has been merged and will release with version 3.22.0 of the Terraform AWS Provider, later this week. Thank you to @jaysiyani for the implementation. 👍

@bflad bflad closed this as completed Dec 15, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Projects
None yet
Development

No branches or pull requests

2 participants