Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECR: Add Image URI as an Attribute for the image data source #13671

Closed
dcherman opened this issue Jun 8, 2020 · 8 comments · Fixed by #24526
Closed

ECR: Add Image URI as an Attribute for the image data source #13671

dcherman opened this issue Jun 8, 2020 · 8 comments · Fixed by #24526
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ecr Issues and PRs that pertain to the ecr service.
Milestone

Comments

@dcherman
Copy link

dcherman commented Jun 8, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Expose Image URI as an output attribute for the aws_ecr_image data source since it would be useful in many areas. For example, passing it to ECS for a task def, or Kubernetes as the image in a pod.

While it's absolutely possible to construct it yourself, it feels like this is a common enough use case that it'd be nice to expose it for users.

New or Affected Resource(s)

  • aws_ecr_image
@dcherman dcherman added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 8, 2020
@ghost ghost added the service/ecr Issues and PRs that pertain to the ecr service. label Jun 8, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 8, 2020
@dcherman
Copy link
Author

dcherman commented Jun 8, 2020

Happy to make a PR for this if it's something the provider would accept.

@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Jul 15, 2020
@jessefarinacci
Copy link

It would also be useful with aws_lambda_function.image_uri configuration. Right now I have to create a pretty horrible looking URI manually..

@cliedeman
Copy link

cliedeman commented Feb 15, 2021

What am I using in the mean time

"${data.aws_ecr_repository.registry.repository_url}@${data.aws_ecr_image.image.image_digest}"

@RemyNtshaykolo
Copy link

What am I using in the mean time

"${data.aws_ecr_repository.registry.repository_url}@${data.aws_ecr_image.image.image_digest}"

thanks!

@Oriho
Copy link

Oriho commented Mar 24, 2022

I need to have Terraform to deploy ECS Farget,the image stored in ECR

weaversam8 added a commit to weaversam8/terraform-provider-aws that referenced this issue May 3, 2022
@weaversam8
Copy link
Contributor

I've authored a pull request that addresses this issue here: #24526.

@breathingdust breathingdust added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2023
@johnsonaj johnsonaj self-assigned this Dec 14, 2023
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 15, 2023
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/ecr Issues and PRs that pertain to the ecr service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants