Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cloudformation RegisterType #12583

Closed
vibhuyadav opened this issue Mar 30, 2020 · 2 comments · Fixed by #18579
Closed

Add Cloudformation RegisterType #12583

vibhuyadav opened this issue Mar 30, 2020 · 2 comments · Fixed by #18579
Assignees
@bflad
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/cloudformation Issues and PRs that pertain to the cloudformation service.
Milestone
v3.38.0

Comments

@vibhuyadav
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS Cloudformation RegisterType feature is missing from the provider

New or Affected Resource(s)

  • aws_cloudformation_stack

References

https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_RegisterType.html
@vibhuyadav vibhuyadav added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 30, 2020
@ghost ghost added the service/cloudformation Issues and PRs that pertain to the cloudformation service. label Mar 30, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 30, 2020
@bflad bflad added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 31, 2021
@bflad bflad self-assigned this Apr 5, 2021
bflad added a commit that referenced this issue Apr 6, 2021
@bflad
service/cloudformation: New Resource and Data Source: aws_cloudformat…
884a0a0 
…ion_type

Reference: #12583

Please note: The handler binary is not included to prevent adding a large file to the repository. The test skip messaging includes directions how to generate it locally, if desired.

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAwsCloudformationType_basic (145.29s)
--- PASS: TestAccAwsCloudformationType_disappears (160.15s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (145.92s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (147.60s)

--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Private (146.49s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (12.57s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Private (144.70s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Public (12.46s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAwsCloudformationType_basic (157.19s)
--- PASS: TestAccAwsCloudformationType_disappears (147.02s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (146.99s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (159.26s)

--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Private (147.32s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (18.42s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Private (147.18s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Public (18.35s)
```
@bflad bflad mentioned this issue Apr 6, 2021
Merged
bflad added a commit that referenced this issue Apr 20, 2021
@bflad @ewbankkit
service/cloudformation: New Resource and Data Source: aws_cloudformat…
a803491 
…ion_type (#18579)

* service/cloudformation: New Resource and Data Source: aws_cloudformation_type

Reference: #12583

Please note: The handler binary is not included to prevent adding a large file to the repository. The test skip messaging includes directions how to generate it locally, if desired.

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAwsCloudformationType_basic (145.29s)
--- PASS: TestAccAwsCloudformationType_disappears (160.15s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (145.92s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (147.60s)

--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Private (146.49s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (12.57s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Private (144.70s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Public (12.46s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAwsCloudformationType_basic (157.19s)
--- PASS: TestAccAwsCloudformationType_disappears (147.02s)
--- PASS: TestAccAwsCloudformationType_ExecutionRoleArn (146.99s)
--- PASS: TestAccAwsCloudformationType_LoggingConfig (159.26s)

--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Private (147.32s)
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (18.42s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Private (147.18s)
--- PASS: TestAccAwsCloudformationTypeDataSource_TypeName_Public (18.35s)
```

* Update CHANGELOG for 18579

* docs/resource/aws_cloudformation_type: Fix typo

* tests/data-source/aws_cloudformation_type: Fix AWSAT005 report

Output from acceptance testing:

```
--- PASS: TestAccAwsCloudformationTypeDataSource_Arn_Public (11.22s)
```

* Apply suggestions from code review

Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>

Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 20, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/cloudformation Issues and PRs that pertain to the cloudformation service.
Projects
None yet
Milestone
v3.38.0
2 participants
@bflad @vibhuyadav